Skip to content

Support separators in floating point literals #1385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 13, 2020
Merged

Support separators in floating point literals #1385

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
82d64d8
Support separators in floating point literals
invalid-email-address Jul 10, 2020
bc05fbf
Add missing return type and use replaceAll
invalid-email-address Jul 10, 2020
d889fd1
@ts-ignore a replaceAll call
invalid-email-address Jul 10, 2020
0b91fe9
Update ts target to esnext
invalid-email-address Jul 10, 2020
6c2440e
Disallow leading 0_
invalid-email-address Jul 10, 2020
8117c06
Add ESNext libs to tsconfig
invalid-email-address Jul 10, 2020
bd6b5eb
Optimize tokenizing floats with separators
invalid-email-address Jul 11, 2020
3e709c3
Move esnext libs to portable compiler options
invalid-email-address Jul 11, 2020
ce27f4e
Merge branch 'master' into float-separators
invalid-email-address Jul 11, 2020
21b1bb1
Add integer to count separators
invalid-email-address Jul 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/tokenizer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1483,7 +1483,6 @@ export class Tokenizer extends DiagnosticEmitter {
this.readDecimalFloatPartial();
}
}
// @ts-ignore
let floatString = text.substring(start, this.pos).replaceAll("_", "");
return parseFloat(floatString);
}
Expand Down
2 changes: 1 addition & 1 deletion src/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"outDir": "../out",
"allowJs": false,
"sourceMap": true,
"target": "ES2016",
"target": "esnext",
"strict": true
},
"include": [
Expand Down