Skip to content

More parser & tokenizer refactorings #1376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jul 10, 2020
Merged

More parser & tokenizer refactorings #1376

merged 13 commits into from
Jul 10, 2020

Conversation

@MaxGraey
Copy link
Member

@MaxGraey MaxGraey commented Jul 4, 2020

  • I've read the contributing guidelines

@MaxGraey MaxGraey changed the title More refactoring for parser More parser & tokenizer refactorings Jul 5, 2020
@MaxGraey
Copy link
Member Author

MaxGraey commented Jul 5, 2020 •
edited
Loading

self-compilation before:

Parse      :   471.000 ms  n=144
Initialize :    29.988 ms  n=1
Compile    :  1394.814 ms  n=1

self-compilation after:

Parse      :   441.361 ms  n=144
Initialize :    29.474 ms  n=1
Compile    :  1473.631 ms  n=1

@dcodeIO not so significant so up to you merge this or not

dcodeIO
dcodeIO reviewed Jul 9, 2020
View reviewed changes
@dcodeIO dcodeIO merged commit fbba2e4 into AssemblyScript:master Jul 10, 2020
@MaxGraey MaxGraey deleted the refactorings branch July 10, 2020 21:30
@github-actions
Copy link

github-actions bot commented Jul 11, 2020

🎉 This PR is included in version 0.13.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@pulpdrew pulpdrew mentioned this pull request Jul 11, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dcodeIO dcodeIO dcodeIO left review comments

Assignees

No one assigned

Labels

enhancement performance released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MaxGraey @dcodeIO