Skip to content

feat(std): add isPowerOf2 helper #1348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 20, 2020
Merged

feat(std): add isPowerOf2 helper #1348

merged 2 commits into from
Jun 20, 2020

Conversation

@MaxGraey
Copy link
Member

@MaxGraey MaxGraey commented Jun 19, 2020

  • I've read the contributing guidelines

@MaxGraey MaxGraey requested a review from dcodeIO June 19, 2020 09:45
@dcodeIO
Copy link
Member

dcodeIO commented Jun 19, 2020

There is a similar helper in src/util/math.ts that is named isPowerOf2. Perhaps name the one here isPowerOf2 as well?

@MaxGraey MaxGraey changed the title feat(std): add isPowOfTwo helper feat(std): add isPowerOf2 helper Jun 19, 2020
@dcodeIO dcodeIO merged commit d5a2959 into AssemblyScript:master Jun 20, 2020
@MaxGraey MaxGraey deleted the is-pow-of-2 branch June 20, 2020 06:55
@github-actions
Copy link

github-actions bot commented Jun 26, 2020

🎉 This PR is included in version 0.12.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dcodeIO dcodeIO Awaiting requested review from dcodeIO

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MaxGraey @dcodeIO