#1059: Add support for floating numbers separator #1093
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks! You should add your name and email to NOTICE file first. |
Member
|
It also makes sense to handle and throw error for invalid cases like: _123.0
123_.0
123._0
123.0_
0_0.0_0 |
MaxGraey
reviewed
Feb 5, 2020
| } | ||
| } | ||
| return parseFloat(text.substring(start, this.pos)); | ||
| return parseFloat(text.substring(start, this.pos).replace(/_/g, '')); |
MaxGraey
reviewed
Feb 5, 2020
| /** Tests if the specified character code is a valid decimal digit. */ | ||
| export function isDecimalDigit(c: i32): bool { | ||
| return c >= CharCode._0 && c <= CharCode._9; | ||
| return c >= CharCode._0 && c <= CharCode._9 ; |
Member
There was a problem hiding this comment.
nit: unnecessary space between semicolon and _9
dcodeIO
reviewed
Feb 9, 2020
|
|
||
| while (this.pos < end) { | ||
| let ch = text.charCodeAt(this.pos); | ||
| if (!(isDecimalDigit(ch) || isDecimalSeparator(ch))) break; |
Member
There was a problem hiding this comment.
This looks like it would accept ___123___123___.___123___. Is that valid?
Member
|
Closing this PR as part of 2020 vacuum as it appears to be stale. Looks like not much was missing here to get it working, so feel free to open a new PR addressing the comments left so far. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1059: Add support for floating numbers separator