Browser support + marginally smaller modules #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is just a small micro-optimization using converge and inline.always to remove a few bytes off of the final .wasm size. Sadly, we can't use "shrinkLevel": 3 since that gives imprecise results.
This confused me for a couple minutes when testing out "shrinkLevel": 3.
Browsers don't have Node.js's Buffer, nor do they have any reasonable way to decode base64. Luckily, `WebAssembly.instantiateStreaming` allows using the results of `fetch`, which in turn can accept base64 data URIs.
HerrCai0907
approved these changes
May 28, 2025
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Browsers don't have
Buffer, but we can usefetchwith data URIs withWebAssembly.instantiateStreaming.One caveat: AssemblyScript supports Node v18+, but
WebAssembly.instantiateStreamingwas added in v18.1.0. This means AssemblyScript would have to bump itsengines.nodeto be>=18.1.0, which is a breaking change but not a particularly impactful one. We can also just bump it to>=20since Node v18 has reached end-of-life.