This repository was archived by the owner on Apr 1, 2025. It is now read-only.
Map optional transcript params to transcript params using JSON #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mapping of optional transcript params to transcript params was manual and not maintainable.
This PR converts the optional params to JSON, sets the audio_url, and then deserializes it to transcript params.
This is not the most performant solution, as handwriting would be, and using a mapper would be second fastest at the cost of an additional dependency.
But this is a better solution for now as we won't accidentally not copy new parameters if we don't maintain the manual mapping code.