This repository was archived by the owner on Apr 1, 2025. It is now read-only.
🌿 Fern Regeneration -- August 26, 2024 #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swimburger
reviewed
Aug 26, 2024
| BaseUrl = _client.Options.BaseUrl, | ||
| Method = HttpMethod.Get, | ||
| Path = $"v2/transcript/{transcriptId}/{formatSlug}", | ||
| Path = $"v2/transcript/{transcriptId}/{subtitleFormat}", |
There was a problem hiding this comment.
This should be subtitleFormat.Stringify().
Swimburger
reviewed
Aug 26, 2024
| public HttpClient HttpClient { get; init; } = new HttpClient(); | ||
|
|
||
| /// <summary> | ||
| /// The http client used to make requests. |
There was a problem hiding this comment.
This doc comment is incorrect.
Swimburger
reviewed
Aug 26, 2024
| }, | ||
| cancellationToken | ||
| ); | ||
| var responseBody = await response.Raw.Content.ReadAsStringAsync(); |
There was a problem hiding this comment.
cancellationToken should be passed to response.Raw.Content.ReadAsStringAsync too
There was a problem hiding this comment.
Anything that's async usually
There was a problem hiding this comment.
Also .ConfigureAwait(false)
There was a problem hiding this comment.
You'll need to use conditional compilation tho:
#if NET6_0_OR_GREATER
var responseBody = await response.Raw.Content.ReadAsStringAsync(cancellationToken).ConfigureAwait(false);
#else
var responseBody = await response.Raw.Content.ReadAsStringAsync().ConfigureAwait(false);
#endif
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR regenerates code to match the latest API Definition.