Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: gradient-color heading #100

Closed

Conversation

DalpatRathore
Copy link
Contributor

Hello @Ashutosh00710 and @Kshitij978
     I have contributed gradient-color heading this time, as can be seen in the below-given screenshots. Please review this change.

  • dark mode view
    gradient-heading-2

  • light mode view
    gradient-heading-1

Copy link
Collaborator

@Kshitij978 Kshitij978 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, @DalpatRathore. Thanks for the effort! ✨ Gradient colors used are not much appealing. Maybe the relevant combination of only two colors that would blend perfectly with the whole UI will work?

@DalpatRathore
Copy link
Contributor Author

Thanks, @Kshitij978 for reviewing. You suggest which color combination you want or we should stay with no colors (original).

@Kshitij978
Copy link
Collaborator

@DalpatRathore Sure, I'll experiment with few colors and let you know. In the meantime you can visit here and try too. 😀

@Kshitij978
Copy link
Collaborator

Hi! @DalpatRathore, Sorry for reverting back late. Let's keep it original for now. I'm doing some changes to the website. We will decide about gradient after the changes.

@DalpatRathore
Copy link
Contributor Author

No problem @Kshitij978. Should I close this pull request or let it remain till changes from your side.

@Kshitij978
Copy link
Collaborator

@DalpatRathore I have created a new discussion tab for this pull request. We will discuss about it there. For now I'm closing this pull request.

@Kshitij978 Kshitij978 closed this Jan 17, 2022
@DalpatRathore
Copy link
Contributor Author

All right. One more thing I wanna ask u is that I have tinkered around this web logo, therefore should I create a new pull request with an enhancement label or you wanna combine this also with gradient heading discussion.

@DalpatRathore DalpatRathore deleted the gradient-heading branch January 17, 2022 17:22
@Kshitij978
Copy link
Collaborator

@DalpatRathore can you send a screenshot in discussion?

@DalpatRathore
Copy link
Contributor Author

Thanks.

Happy Coding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants