fix(i18n): configuration loss when switching locale #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When this feature came out, I really wanted to implement this, but I didn't have the time. Thank you for getting it done. |
JunkFood02
force-pushed
the
fix_locale
branch
from
06d7c93
to
cb92fd7
Compare
|
Is this ready? |
Not really, the next step is to add the new available languages to the in-app language picker for backward compatibility |
Ashinch
pushed a commit
that referenced
this pull request
Feb 6, 2024
* fix(i18n): configuration loss when switching locale * feat(locale): enable auto-localeconfig
Ashinch
added a commit
that referenced
this pull request
Feb 6, 2024
* build(deps): bump up dependencies, compile sdk, and gradle version (#502) * build(deps): bump up dependencies, compile sdk, and gradle version * build(deps): remove redundant safe-args plugin * build(deps): update Compose BOM to `2024.01.00` & compiler to `1.5.8` * fix(i18n): configuration loss when switching locale (#541) * fix(i18n): configuration loss when switching locale * feat(locale): enable auto-localeconfig * feat(i18n): add languages to in-app language picker (#571) * feat(i18n): add languages to in-app language picker * fix(i18n): locale system settings not working for Android 13 * feat(i18n): show selected language at settings page * fix(ci): ignore ExtraTranslation for linter * feat(i18n): add fallback in in-app language picker for A13+ * chore: clean up * fix(ui): ProgressIndicator crashes in m3 1.1.2 * fix(ui): NavigationBarItem color * feat(ui): grey out read articles even if starred (#547) * refactor(ui): improve add account dialog * fix(ui): accessing listState on io thread causes app to crash * fix(ui): NavigationBar text color * feat(ui): show full screen image viewer when clicking on images (#578) * feat(ui): add crash report activity to handle uncaught exceptions (#576) * feat(ui): swipe up and down to switch between articles (WIP) * feat(ui): update animation * docs(ui): add comments on pull to load implementation * feat(ui): move the indicator to another file * build: revert changes * feat(ui): make the transition directions match the content changes --------- Co-authored-by: MauroGuida <[email protected]> Co-authored-by: Ash <[email protected]> Co-authored-by: Ash <[email protected]>
This was referenced Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?