fix(activities): clarify bulk selection - #2344
Merged
Merged
Conversation
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
|
🤖 Review skipped: Repository rate limit exceeded. Free accounts are limited to 2 reviews per 4 hours per repository. Upgrade to a paid plan for unlimited reviews. |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
Reviewer's GuideClarifies and standardizes bulk activity selection UX across web and mobile, adding explicit guidance text, accessible live selection counts, and targeted tests/stories around the selection mode. Sequence diagram for clarified bulk activity selection and live status updatessequenceDiagram
actor User
participant ActivitiesPage
participant ActivityControls
participant ScreenReader
User->>ActivitiesPage: fireEvent_click_Select_activities_button
ActivitiesPage->>ActivityControls: onSelect
ActivityControls->>ActivityControls: render_selectionGuidance
ActivityControls->>ActivityControls: render_selectedCountLabel("0 activities selected")
ActivityControls-->>ScreenReader: aria_live_update("0 activities selected")
User->>ActivitiesPage: fireEvent_click_activity_card
ActivitiesPage->>ActivityControls: update_selectedActivityIds
ActivityControls->>ActivityControls: render_selectedCountLabel("1 activity selected")
ActivityControls-->>ScreenReader: aria_live_update("1 activity selected")
File-Level Changes
Assessment against linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
PR Summary by QodoClarify activity bulk selection labels and accessible counts
AI Description
Diagram
High-Level Assessment
Files changed (9)
|
📝 WalkthroughWalkthroughThe update clarifies bulk activity selection on web and mobile by renaming controls, adding bulk-action guidance, announcing singular/plural selection counts, and covering the behavior with tests and Storybook stories. ChangesActivity bulk selection
Estimated code review effort: 3 (Moderate) | ~20 minutes Assessment against linked issues
Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 1 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (1 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Code Review by Qodo
Context used✅ Compliance rules (platform):
186 rules✅ Skills:
fix-provider, write-tests, cloudflare 1.
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
Contributor
|
Storybook previews for This comment updates automatically on each PR push. |
Contributor
Mobile PreviewScan to open on device:
To test on device:
|
Prevent duplicate aria-describedby targets when multiple activity controls mount.\n\nRefs #2122
|
🤖 Review skipped: Repository rate limit exceeded. Free accounts are limited to 2 reviews per 4 hours per repository. Upgrade to a paid plan for unlimited reviews. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/superpowers/plans/2026-07-30-activity-bulk-selection.md`:
- Around line 3-4: Remove the agent-only “REQUIRED SUB-SKILL” instruction from
the plan document while preserving the checkbox step guidance. If this
instruction must remain available to agents, relocate it to the applicable
AGENTS.md rather than keeping it under docs/**.
In `@packages/mobile/app/`(tabs)/activities.tsx:
- Around line 455-456: Update the selected-count announcement flow around
selectedCountLabel to call
AccessibilityInfo.announceForAccessibility(selectedCountLabel) on iOS, while
preserving the existing accessibilityLiveRegion behavior for Android.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 0cc08faa-bf58-47e7-a914-2b03c6648d51
📒 Files selected for processing (9)
docs/superpowers/plans/2026-07-30-activity-bulk-selection.mdpackages/mobile/app/(tabs)/activities.stories.tsxpackages/mobile/app/(tabs)/activities.test.tsxpackages/mobile/app/(tabs)/activities.tsxpackages/web/src/components/ActivityList.stories.tsxpackages/web/src/components/ActivityList.test.tsxpackages/web/src/components/ActivityList.tsxpackages/web/src/pages/ActivitiesPage.test.tsxpackages/web/src/pages/ActivitiesPage.tsx
Keep Android live-region behavior while explicitly announcing selection count changes to VoiceOver, and remove agent-only instructions from the human plan.\n\nRefs #2122
|
🤖 Review skipped: Repository rate limit exceeded. Free accounts are limited to 2 reviews per 4 hours per repository. Upgrade to a paid plan for unlimited reviews. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
pnpm lintpnpm tsc --noEmitpnpm --dir packages/server exec tsc --noEmitpnpm --dir packages/web typecheckpnpm --dir packages/mobile typecheckpnpm test(15,057 passed; 21 skipped)Fixes #2122
Summary by Sourcery
Clarify activity bulk selection UI and announce accessible selection counts across web and mobile.
New Features:
Enhancements:
Documentation:
Tests:
Summary by cubic
Clarifies bulk activity selection on web and mobile by renaming the entry point to "Select activities", adding clear per-surface guidance, and announcing selection counts as accessible status (including explicit iOS announcements). Also explains delete vs. restore for hidden activities on web. Fixes #2122.
packages/web): Show "Select activities"; add guidance text with a unique id per control and link it viaaria-describedby; expose the count via a polite, atomicoutputstatus; hidden view explains delete or restore.packages/mobile): Show "Select activities" with a hint; display guidance; announce the count with a polite live region and proper singular/plural text; on iOS, also announce count changes viaAccessibilityInfo.announceForAccessibility.Written for commit 26876dc. Summary will update on new commits.
Summary by CodeRabbit
Accessibility
Documentation