feat(lint): implement vue/noSetupPropsReactivityLoss Part2#1
Closed
AsherDe wants to merge 1 commit intofeat/vue-reactivity-rulefrom
Closed
feat(lint): implement vue/noSetupPropsReactivityLoss Part2#1AsherDe wants to merge 1 commit intofeat/vue-reactivity-rulefrom
AsherDe wants to merge 1 commit intofeat/vue-reactivity-rulefrom
Conversation
…e setup function body (e.g., const { count } = props;).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR extends the
noVueSetupPropsReactivityLossrule to detect props destructuring in the setup function body, not just in parameters.PR#7513
Test Plan
Added comprehensive test coverage with 9 new test files covering:
Invalid cases (should report errors):
setup(props) { const { count } = props; }setup: (props) => { const { count } = props; }({ count } = props);const [first] = props;defineComponent()and plain object literalsValid cases (should not report):
toRefs(props)vue,@vue/reactivity,@vue/composition-apiVue.toRefs(props)import { toRefs as makeRefs }export default)All tests pass:
File type support verified:
.jsfiles.tsfiles.vuefiles (extracts and checks<script>content)