Skip to content

Revert "Use LazyValue for routed_experts_weights_of_layer initialization"#161

Merged
Hexq0210 merged 4 commits intoAscend:release/PoC_20260331from
longxin9715:main
Mar 28, 2026
Merged

Revert "Use LazyValue for routed_experts_weights_of_layer initialization"#161
Hexq0210 merged 4 commits intoAscend:release/PoC_20260331from
longxin9715:main

Conversation

@longxin9715
Copy link
Copy Markdown

@longxin9715 longxin9715 commented Mar 28, 2026

PR Title

Revert "Use LazyValue for routed_experts_weights_of_layer initialization"

Motivation

Original PR :sgl-project#15904
Revert the modification of wrapping routed_experts_weights_of_layer with LazyValue.
After using LazyValue, the expert load balancing logic fails to execute correctly, causing runtime errors in MoE expert scheduling and load balancing.
Restore the original direct initialization to ensure normal operation of expert load balancing.

Modifications

  1. Revert code block of routed_experts_weights_of_layer assignment logic
  2. Remove LazyValue wrapper and lambda expression
  3. Restore original direct dict eager initialization implementation

Accuracy Tests

N/A
Pure logic revert, no impact on model accuracy and output results.

Benchmarking and Profiling

N/A
No inference performance changes introduced.

Checklist

Review Process

  1. Ping Merge Oncalls to start the PR flow. See the PR Merge Process.
  2. Get approvals from CODEOWNERS and other reviewers.
  3. Trigger CI tests with comments or contact authorized users to do so.
    • /tag-run-ci-label, /rerun-failed-ci, /tag-and-rerun-ci
  4. After green CI and required approvals, ask Merge Oncalls to merge.

@ascend-robot
Copy link
Copy Markdown

CLA Signature Guide

@longxin9715 , thanks for your pull request.

The following commit(s) are not associated with a signed Contributor License Agreement (CLA).

Commit Reason
2a5e5e8c Fix bug the email used in the commit is not linked to a signed CLA!
please verify that it matches the email you used when signing the CLA.
b05b0b4b Merge branch 'main' into main the email used in the commit is not linked to a signed CLA!
please verify that it matches the email you used when signing the CLA.

To sign CLA, click here.

To check if your email is configured correctly, refer to the FAQs.

Once you've signed the CLA or updating your email, please comment /check-cla to revalidate CLA status.

iforgetmyname
iforgetmyname previously approved these changes Mar 28, 2026
j30065060 added 2 commits March 28, 2026 17:53
* origin/main:
  [MLX] Add native MLX execution backend for Apple Silicon Mac (sgl-project#20342)
  [Diffusion] Refactor diffusion JIT kernel test layout and narrow CI triggers (sgl-project#21385)
  [CI] Add PID namespace and ps auxf diagnostics to killall.py (sgl-project#21401)
@ascend-robot
Copy link
Copy Markdown

CLA Signature Guide

@longxin9715 , thanks for your pull request.

The following commit(s) are not associated with a signed Contributor License Agreement (CLA).

Commit Reason
2a5e5e8c Fix bug the email used in the commit is not linked to a signed CLA!
please verify that it matches the email you used when signing the CLA.
b05b0b4b Merge branch 'main' into main the email used in the commit is not linked to a signed CLA!
please verify that it matches the email you used when signing the CLA.

To sign CLA, click here.

To check if your email is configured correctly, refer to the FAQs.

Once you've signed the CLA or updating your email, please comment /check-cla to revalidate CLA status.

@Hexq0210 Hexq0210 merged commit 6c54ed0 into Ascend:release/PoC_20260331 Mar 28, 2026
1 check passed
@iridiumine iridiumine mentioned this pull request Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants