[NPU] fix rope_theta get error for baichuan2-13b-chat model#158
Open
ZeyuanChen2000 wants to merge 2 commits intoAscend:release/PoC_20260331from
Open
[NPU] fix rope_theta get error for baichuan2-13b-chat model#158ZeyuanChen2000 wants to merge 2 commits intoAscend:release/PoC_20260331from
ZeyuanChen2000 wants to merge 2 commits intoAscend:release/PoC_20260331from
Conversation
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
CLA Signature Guide@ZeyuanChen2000 , thanks for your pull request. The following commit(s) are not associated with a signed Contributor License Agreement (CLA).
To sign CLA, click here. To check if your email is configured correctly, refer to the FAQs. Once you've signed the CLA or updating your email, please comment |
CLA Signature Guide@ZeyuanChen2000 , thanks for your pull request. The following commit(s) are not associated with a signed Contributor License Agreement (CLA).
To sign CLA, click here. To check if your email is configured correctly, refer to the FAQs. Once you've signed the CLA or updating your email, please comment |
Author
|
前置需要先合入PR sgl-project#21135 |
|
approve |
1 similar comment
|
approve |
Hide-on-bushsh
approved these changes
Mar 30, 2026
iforgetmyname
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
PR sgl-project#21135 use function
get_rope_config()to directly getconfig.rope_theta, while in modelbaichuan-inc/Baichuan2-13B-Chat, itsconfig.jsondoesn't have this attribute.Affected trust-remote-code models:
Baichuan2-13B-Chat
Modifications
in function
get_rope_config(), provide a reasonable default(10000) value whenrope_thetais missingAccuracy Tests
Benchmarking and Profiling
Checklist
Review Process
/tag-run-ci-label,/rerun-failed-ci,/tag-and-rerun-ci