Skip to content

[NPU] fix rope_theta get error for baichuan2-13b-chat model#158

Open
ZeyuanChen2000 wants to merge 2 commits intoAscend:release/PoC_20260331from
ZeyuanChen2000:baichun2-13b-chat
Open

[NPU] fix rope_theta get error for baichuan2-13b-chat model#158
ZeyuanChen2000 wants to merge 2 commits intoAscend:release/PoC_20260331from
ZeyuanChen2000:baichun2-13b-chat

Conversation

@ZeyuanChen2000
Copy link
Copy Markdown

Motivation

PR sgl-project#21135 use function get_rope_config() to directly get config.rope_theta, while in model baichuan-inc/Baichuan2-13B-Chat, its config.json doesn't have this attribute.

image

Affected trust-remote-code models:
Baichuan2-13B-Chat

Modifications

in function get_rope_config(), provide a reasonable default(10000) value when rope_theta is missing

Accuracy Tests

Benchmarking and Profiling

Checklist

Review Process

  1. Ping Merge Oncalls to start the PR flow. See the PR Merge Process.
  2. Get approvals from CODEOWNERS and other reviewers.
  3. Trigger CI tests with comments or contact authorized users to do so.
    • /tag-run-ci-label, /rerun-failed-ci, /tag-and-rerun-ci
  4. After green CI and required approvals, ask Merge Oncalls to merge.

chenzeyuan and others added 2 commits March 27, 2026 17:17
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@ascend-robot
Copy link
Copy Markdown

CLA Signature Guide

@ZeyuanChen2000 , thanks for your pull request.

The following commit(s) are not associated with a signed Contributor License Agreement (CLA).

Commit Reason
[2d2a4f8 [NPU] fix rope_theta get error ...](2d2a4f8) the email used in the commit is not linked to a signed CLA!
please verify that it matches the email you used when signing the CLA.
c0686ba6 Apply suggestion from @gemini-co... the email used in the commit is not linked to a signed CLA!
please verify that it matches the email you used when signing the CLA.

To sign CLA, click here.

To check if your email is configured correctly, refer to the FAQs.

Once you've signed the CLA or updating your email, please comment /check-cla to revalidate CLA status.

@ascend-robot
Copy link
Copy Markdown

CLA Signature Guide

@ZeyuanChen2000 , thanks for your pull request.

The following commit(s) are not associated with a signed Contributor License Agreement (CLA).

Commit Reason
[2d2a4f8 [NPU] fix rope_theta get error ...](2d2a4f8) the email used in the commit is not linked to a signed CLA!
please verify that it matches the email you used when signing the CLA.
c0686ba6 Apply suggestion from @gemini-co... the email used in the commit is not linked to a signed CLA!
please verify that it matches the email you used when signing the CLA.

To sign CLA, click here.

To check if your email is configured correctly, refer to the FAQs.

Once you've signed the CLA or updating your email, please comment /check-cla to revalidate CLA status.

@ZeyuanChen2000
Copy link
Copy Markdown
Author

前置需要先合入PR sgl-project#21135

@Hide-on-bushsh
Copy link
Copy Markdown

approve

1 similar comment
@qinsir5522
Copy link
Copy Markdown

approve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants