Skip to content

[NPU] recover accuracy for gemma3-4b-it from 54% to 72% (reduced by transformer5.3) #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Hexq0210 merged 2 commits into from
Mar 28, 2026
Merged

[NPU] recover accuracy for gemma3-4b-it from 54% to 72% (reduced by transformer5.3) #155

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c2a0580
[NPU] recover accuracy for gemma3-4b-it for transformer5.3
McZyWu Mar 27, 2026
321735d
fix lint checks
McZyWu Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 19 additions & 5 deletions python/sglang/srt/models/gemma3_causal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,16 @@
default_weight_loader,
maybe_remap_kv_scale_name,
)
from sglang.srt.utils import add_prefix, cpu_has_amx_support, is_cpu, make_layers
from sglang.srt.utils import (
add_prefix,
cpu_has_amx_support,
is_cpu,
is_npu,
make_layers,
)

_is_cpu = is_cpu()
_is_npu = is_npu()
_is_cpu_amx_available = cpu_has_amx_support()


Expand Down Expand Up @@ -573,10 +580,17 @@ def __init__(
local_theta = getattr(config, "rope_local_base_freq", 10000.0)

global_config = copy.deepcopy(config)
global_config.rope_parameters = {
"rope_type": "default",
"rope_theta": global_theta,
}
if not _is_npu:
global_config.rope_parameters = {
"rope_type": "default",
"rope_theta": global_theta,
}
else:
global_config.rope_parameters = {
"rope_theta": global_theta,
"factor": 8,
"rope_type": "linear",
}
self.rotary_emb = Gemma3RotaryEmbedding(config=global_config)
self.gradient_checkpointing = False

Expand Down
Loading