Conversation
sgl-project/sglang PR sgl-project#37091 added result: InsertResult to several TreeComponent hooks and the insert walk now calls them with result=.... C128SidecarComponent.recover_after_unevict still uses the old signature and raises TypeError on the evict->unevict path. Add a signature-parity unit test so the NPU subclass cannot drift from the base contract.
CLA Signature Guide@EdwardXuy , thanks for your pull request. The following commit(s) are not associated with a signed Contributor License Agreement (CLA).
To sign CLA, click here. To check if your email is configured correctly, refer to the FAQs. Once you've signed the CLA or updating your email, please comment |
CLA Signature Guide@EdwardXuy , thanks for your pull request. The following commit(s) are not associated with a signed Contributor License Agreement (CLA).
To sign CLA, click here. To check if your email is configured correctly, refer to the FAQs. Once you've signed the CLA or updating your email, please comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sgl-project/sglang PR sgl-project#37091 ([Unified Cache][1/N]: Support cache contract for external linker) added a required
esult: InsertResult parameter to several TreeComponent lifecycle hooks, and the insert walk now calls them with
esult=... as a keyword argument.
The NPU C128SidecarComponent (auto-registered for DeepSeek-V4 into the unified radix cache) overrides
ecover_after_unevict with the old signature, which makes the evict -> unevict path raise:
What this PR does
Adds a CPU unit test ( est_npu_c128_sidecar_contract.py) that asserts the NPU sidecar stays signature-compatible with the base TreeComponent contract methods (update_component_on_insert_overlap,
ecover_after_unevict, commit_insert_component_data).
This reproduces the bug: it fails on main and passes once C128SidecarComponent.recover_after_unevict accepts
esult: InsertResult.
CI
Registered via
egister_cpu_ci (CPU suite); no NPU image / model is required.
CI States
Latest PR Test (Base): ❌ Run #33490869887
Latest PR Test (Extra): ❌ Run #33490870065
Latest PR Test (AMD ROCm 7.2): ❌ Run #33490869852