Allow position specifiers in stringsdict variables #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevelandeyasana
force-pushed
the
steve/recognize-positioned-stringsdict-args
branch
from
eb6b922
to
0bb2469
Compare
asana-jau
reviewed
Apr 26, 2023
| @@ -78,7 +78,7 @@ struct Expressions { | |||
| pattern: Expressions.nativeArgumentExpression, | |||
| options: []) | |||
|
|
|||
| private static let stringsdictArgumentExpression = #"%#@(?<name>.+?)@"# | |||
| private static let stringsdictArgumentExpression = #"%[0-9]*\$?#@(?<name>.+?)@"# | |||
There was a problem hiding this comment.
strictly speaking, shouldn't there be parentheses around [0-9]*\$ so that the entire thing is question-marked at once or not at all?
i.e. the latter instead of the former, since the last two are spurious matches that are incorrect syntax afaik?
asana-jau
approved these changes
Apr 26, 2023
mary-xu
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://www.oneskyapp.com/academy/learn-ios-localization/2-format-strings-plurals/