Split server_side_encryption for s3 bucket into its own resource #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@skeggse OK if I assign this to you as Terraform AOR? Going to merge though since I already |
skeggse
reviewed
Nov 11, 2022
Comment on lines
+355
to
363
| resource "aws_s3_bucket_server_side_encryption_configuration" "api_key_bucket_server_side_encryption_configuration" { | ||
| bucket = aws_s3_bucket.api_key_bucket.bucket | ||
| rule { | ||
| apply_server_side_encryption_by_default { | ||
| kms_master_key_id = aws_kms_key.api_encryption_key.arn | ||
| sse_algorithm = "aws:kms" | ||
| } | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
tf fmt might be good for this file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion about this here but tldr is that in later versions of the AWS provider, individual configurations on S3 buckets are split out into their own Terraform resources. This was backported to v3.75.2 (which is what we're currently using) to prep for the breaking change.
I already imported into Asana's remote state so this is a no-op
Pull Request synchronized with Asana task