Support being used as a binfmt_misc handler. #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unconditionally forward a range of ports to sockets named `$XDG_RUNTIME_DIR/krun/socket/port-$PORT`. This allows applications to dynamically bind to sockets at those paths and have them forwarded to the guest as vsock ports, after the krun VM is already running. The port range is currently hardcoded as 50000..50200. Signed-off-by: Asahi Lina <[email protected]> Signed-off-by: Sasha Finkelstein <[email protected]>
After launching a process via the server, krun immediately closes and the
launched process' std{in,out,err} go nowhere. Add a --interactive flag that
allocates a pseudo-terminal, routes it to the host and connects to it.
Somewhat like '-it' in docker/podman exec.
Signed-off-by: Sasha Finkelstein <[email protected]>
Aside from just being better UX, some commands are sensitive to it and will not work correctly without it. Signed-off-by: Sasha Finkelstein <[email protected]>
This is always what you want if running via binfmt Signed-off-by: Sasha Finkelstein <[email protected]>
Launches the initial command via the server too. Server is set to linger for 10 seconds after last command finishes. Signed-off-by: Sasha Finkelstein <[email protected]>
Change the approach to environment variables to delete ones that are likely to cause problems instead of only passing through a pre-approved list. This will be neccessary to correctly work as a binfmt handler Fixes: AsahiLinux#52 Signed-off-by: Sasha Finkelstein <[email protected]>
Closes: AsahiLinux#24 Signed-off-by: Sasha Finkelstein <[email protected]>
WhatAmISupposedToPutHere
requested review from
slp and
teohhanhui
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series allows krun to be used as a binfmt_misc handler: it uses interactive launch mode to make sure stdin/stdout are going where users expect, passes through the current working directory, expands the number of environment variables that are passed through, and daemonizes the vm process, so a process that waits on the first process launched via krun is not prevented from progressing by others.