fix(web): improve composer @ file search and popover keyboard scroll - #177
Conversation
Match @ mentions by file/folder name substring only (no fuzzy path hits), highlight the keyword in results, and keep 3 peek rows when arrowing through @ and / popovers (shared by Terminal AI input).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (7)
📝 WalkthroughWalkthroughWelcome mention search now uses ranked case-insensitive substring matching and highlights matching file-name segments. A shared scrolling helper keeps active mention, slash-command, and disabled-skill rows visible within their list containers. ChangesWelcome popover updates
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant User
participant WelcomeMentionPopover
participant MentionSearch
participant PopoverList
User->>WelcomeMentionPopover: enter mention query
WelcomeMentionPopover->>MentionSearch: filter file candidates
MentionSearch-->>WelcomeMentionPopover: ranked candidates
WelcomeMentionPopover->>PopoverList: render highlighted names
User->>WelcomeMentionPopover: navigate candidates
WelcomeMentionPopover->>PopoverList: scroll active row into view
Possibly related PRs
Suggested labels: ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install failed. For unrecoverable errors, disable the tool in CodeRabbit configuration. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
E2E report: ✅ Passed4 passed · 0 failed · 0 flaky · 0 skipped · 1m 41s · 100% pass rate Run
Overview
By file
By project
All selected E2E suites passed. |
This branch was successfully deployed
1 participant
Summary
Optimize composer
@mention file search and shared popover keyboard scrolling (Welcome + Terminal AI input):@file search: match only file/folder names with case-insensitive substring (*keyword*), including hidden names (.…); drop Fuse fuzzy matching on full paths that produced irrelevant hits@and/lists, keep 3 peek rows below/above the active item (selection ~4th from bottom); shared helper used by mention + slash (Terminal reuses the same hooks)Related Issue
N/A
Type of Change
Validation
just lintbun test src/features/welcome/hooks/__tests__/use-welcome-mention-search.test.ts(apps/web)just fmtChecklist
Summary by cubic
Improves composer
@file mention search to match case-insensitive name substrings with clearer ranking and highlighting. Also smooths keyboard navigation in@and/popovers by keeping 3 items visible around the selection with a shared scroll helper.Bug Fixes
@file search now matches name substrings only (case-insensitive), includes hidden names, removes fuzzy full-path noise, returns all matches, and ranks exact/prefix before contains.@and/popovers keeps 3 peek rows around the active item for steadier scrolling.Refactors
scrollActiveListItemIntoViewfor popover lists (Welcome and Terminal).splitHighlightPartsto show why each item matched.Written for commit ecc84d0. Summary will update on new commits.
Summary by CodeRabbit
New Features
Bug Fixes