Repository navigation
docs: G6 — cms-framework integration docs + smoke flow - #472
ViewFromTheBox merged 2 commits into
Conversation
- Flip plan 12 §8 from "open questions" to "decisions made" with the seven kickoff questions resolved against what shipped in G0–G5. - Add "Using with cms-framework" README section covering install, migrations, the merged resource map, and the version-pair contract. - Add docs/g6-smoke-flow.md — manual QA checklist that exercises the full Phase G pipeline end-to-end (mirrors docs/h8-smoke-flow.md for the site-editor side). - Draft V1.0.0 release-notes bullets in CHANGELOG [Unreleased] covering the Phase G integration, README section, and permissions seed. Reciprocal "Using with the visual editor" section in the cms-framework README tracked separately in cms-framework#150. Closes #403
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughDocumentation-only changes completing Phase G: README “Using with cms-framework” guide, a G6 manual QA smoke-flow checklist, updates to the phase plan recording implementation decisions, and related changelog entries. Changescms-framework Integration Documentation
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related issues
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
README.md (1)
25-26:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winInconsistent smoke flow reference for V1.0.x.
This PR adds
docs/g6-smoke-flow.md(Phase G cms-framework integration), but lines 25-26 referencedocs/h8-smoke-flow.md(Phase H site-editor) as the smoke flow that "runs against this version pair before every release tag." For V1.0.x, the cms-framework integration validation should cite the G6 flow.📝 Proposed fix
-Bumping the major on either package without bumping the partner is -unsupported. The H8 smoke flow ([`docs/h8-smoke-flow.md`](docs/h8-smoke-flow.md)) -runs against this version pair before every release tag. +Bumping the major on either package without bumping the partner is +unsupported. The G6 smoke flow ([`docs/g6-smoke-flow.md`](docs/g6-smoke-flow.md)) +runs against this version pair before every V1.0.x release tag.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@README.md` around lines 25 - 26, Update the README.md smoke flow reference to point to the G6 smoke flow: replace the reference to docs/h8-smoke-flow.md with docs/g6-smoke-flow.md so the sentence correctly states that the G6 (cms-framework integration) smoke flow runs against the V1.0.x version pair before every release tag; search for the exact text fragment "runs against this version pair before every release tag" or the current mention of docs/h8-smoke-flow.md to locate the line to change.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@README.md`:
- Around line 25-26: Update the README.md smoke flow reference to point to the
G6 smoke flow: replace the reference to docs/h8-smoke-flow.md with
docs/g6-smoke-flow.md so the sentence correctly states that the G6
(cms-framework integration) smoke flow runs against the V1.0.x version pair
before every release tag; search for the exact text fragment "runs against this
version pair before every release tag" or the current mention of
docs/h8-smoke-flow.md to locate the line to change.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 1c48c495-1d28-42c1-b946-eaaf0b586444
📒 Files selected for processing (4)
CHANGELOG.mdREADME.mddocs/g6-smoke-flow.mddocs/plans/12-cms-framework-integration.md
…version-pair note
Description
Phase G6 of the cms-framework integration (plan 12). Closes out the integration work landed in G0–G5 with documentation, a manual smoke flow, and V1.0.0 release-notes draft.
Closes: #403
Type of Change
Related Issue
Issue: #403
Motivation and Context
G0–G5 shipped the actual integration code (resource filter, site-meta bridge, REST adapters, block re-enablement, permissions seed). G6 is the documentation + release-readiness layer: users need a path from "I installed both packages" to "I'm editing a Post"; we need a manual regression flow that exercises the version pair before every release tag; the V1.0.0 release-notes need to call out the integration explicitly.
Changes Made
content+block_contentstate), the mergedap.visual-editor.resourcesmap, and the version-pair contract.docs/g6-smoke-flow.md— manual QA checklist (A–H steps + failure runbook) that exercises the full Phase G pipeline end-to-end. Mirrorsdocs/h8-smoke-flow.mdfor the site-editor side; G6 covers post / page editing, site-meta, query-loop blocks, and standalone-cms-framework boot.CHANGELOG.md[Unreleased] covering the Phase G integration, README section, and permissions seed. These flow into the V1.0.0 release PR when ship time comes.Reciprocal "Using with the visual editor" section in the cms-framework README tracked separately in cms-framework#150 per the issue body's "file as small follow-up issue" option.
How Has This Been Tested?
Testing Environment:
Tests Performed:
Docs-only change — no PHP or JS code touched, so no test suite affected. CodeRabbit CLI run against
release/1.0returned 0 findings after addressing one math-correction in §8.The smoke flow itself is the test surface for the integration — it will run against the v1.0.0 release candidate per its own "Logging" section.
Accessibility Tests Run
Tests Added
Test details: N/A.
Documentation
Documentation details: All changes are documentation. See "Changes Made" above.
Pre-Submission Checklist
Summary by CodeRabbit