chore: retro-review PR #94 — feat(quality-scale): HACS Silver tickbox + manifest flip (Phase 8 PR-9)#126
Closed
Artic0din wants to merge 2 commits into
Closed
chore: retro-review PR #94 — feat(quality-scale): HACS Silver tickbox + manifest flip (Phase 8 PR-9)#126Artic0din wants to merge 2 commits into
Artic0din wants to merge 2 commits into
Conversation
PR-9 — Closes Phase 8 (Wave 2). manifest.json now declares quality_scale: "silver". Version bumped to 1.6.0-beta.1. - sensor.py declares PARALLEL_UPDATES = 0 (CoordinatorEntity-backed; concurrent reads safe). - __init__.py service handlers raise HomeAssistantError on missing coordinator (was: warn + return) and ServiceValidationError on malformed input (was: warn + default-fallback). Applies to analyze_csv, backfill_history, rank_alternatives. - New quality_scale.yaml documents every Bronze + Silver + Gold + Platinum rule with status (done | exempt | todo) + comments pointing at implementing PRs / decisions. Silver-required rules all "done"; Gold rules "todo" with comment: v4 (or "exempt" for no-device integrations); Platinum mostly "todo". - log-when-unavailable rule documented as "exempt" — DataUpdateCoordinator + CoordinatorEntity already handle availability transitions. - conftest stubs HomeAssistantError + ServiceValidationError. - 13 new tests; 969 total pass. Decisions: DECISIONS.md > D-P8-5. Phase 8 (Silver Compliance / Wave 2) COMPLETE: PR-5 reauth + PR-6 reconfigure + PR-7 diagnostics + PR-8 repairs + PR-9 silver flip. Next milestone: Phase 9 (Wave 3 external statistics) for v2.0 GA. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Owner
Author
|
@claude review |
|
Claude encountered an error after 7m 13s —— View job I'll analyze this and get back to you. |
|
Claude encountered an error after 7m 14s —— View job I'll analyze this and get back to you. |
Owner
Author
|
Retro-review complete. Findings (if any) tracked in fix/retro-review-batch (#143) or noted in .planning/retro-review-findings.md. Closing synthetic PR + cleaning branches. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Synthetic retro-review of merged PR #94. Diff = original
e209784..78e18f4(same as original PR). Do NOT merge; close after @claude review posts.