chore: retro-review PR #88 — feat(providers): Dynamic Wholesale Tariff retailer wiring (Phase 7 PR-2b)#120
Closed
Artic0din wants to merge 2 commits into
Closed
Conversation
…7 PR-2b) PR-2b — Dynamic Wholesale Tariff is now a selectable retailer in PriceHawk's config flow with TWO entries (OpenElectricity, AEMO Direct) backed by ONE DynamicWholesaleTariffProvider class. Both implement the Provider Protocol in the same slot as Amber/Flow Power/LocalVolts. - DynamicWholesaleTariffProvider: self-priced; sync update(); public set_live_price(WholesalePrice) called by the coordinator's async refresh coroutine. 4-minute staleness guard dedups SDK calls against the 5-min dispatch cadence. Negative wholesale prices honoured (exporter pays during curtailment). State persistence honours AEGIS rules (version field + explicit HA-tz date, no date.today() fallback). - coordinator.py: DWT branch in __init__ and rebuild_engine. _refresh_dwt_price coroutine hooked into _async_update_data before the tick loop. ConfigEntryNotReady on inconsistent config (DWT marker without enabled flag). - config_flow.py: async_step_cdr_retailer prepends two synthetic DWT entries + dispatches to new dwt_credentials / dwt_aemo_setup steps. WEM excluded from AEMO Direct (NEMWeb is NEM-only per PR-3). API key validated live against OpenElectricity SDK before entry creation. - strings.json + translations/en.json kept byte-identical (project invariant). - 29 new tests; 868 total pass. Decisions: DECISIONS.md > D-P7-10, D-P7-11. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Owner
Author
|
@claude review |
|
Claude encountered an error after 19m 56s —— View job PR #88 Retro-Review — Dynamic Wholesale Tariff Retailer Wiring (Phase 7 PR-2b)
|
|
Claude encountered an error after 7m 6s —— View job I'll analyze this and get back to you. |
Owner
Author
|
Retro-review complete. Findings (if any) tracked in fix/retro-review-batch (#143) or noted in .planning/retro-review-findings.md. Closing synthetic PR + cleaning branches. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Synthetic retro-review of merged PR #88. Diff = original
20a79b9..a788aa3(same as original PR). Do NOT merge; close after @claude review posts.