Set git_version when .git folder is missing#116
Merged
ArthurSonzogni merged 1 commit intoArthurSonzogni:masterfrom Jun 17, 2021
Merged
Set git_version when .git folder is missing#116ArthurSonzogni merged 1 commit intoArthurSonzogni:masterfrom
ArthurSonzogni merged 1 commit intoArthurSonzogni:masterfrom
Conversation
If we download the FTXUI source archive from the GitHub website, then the `.git` folder will be missing. In such case, CMake configuration will fail: > git found > fatal: not a git repository (or any of the parent directories): .git > CMake Error at CMakeLists.txt:21 (project): > VERSION "0.6." format invalid.
Contributor
Author
|
Please do not merge yet. Let's see if this patch can fix Linux and macOS build errors encountered in microsoft/vcpkg#18360. |
Contributor
Author
|
Hi. @ArthurSonzogni I think this PR is ready now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we download the FTXUI source archive from the GitHub website, then the
.gitfolder will be missing.In such case, CMake configuration will fail: