Skip to content

Conversation

@nthreads
Copy link

@nthreads nthreads commented Sep 5, 2018

Hi,

I've made changes in com.theartofdev.edmodo.cropper.CropOverlayView file to fix the cashing issue device with Android P. Please accept the pull request.

Thanks
Nauman

@PaulWoitaschek
Copy link

@ArthurHub
You have built this library and now it's crashing for every single user on Android P. Can you please take the time reviewing the most critical PR's?

@ArthurHub
Copy link
Owner

well, I defenitly not as engaged as I should be but this is the nature of open-source, I havn't touched Android for more than 2 years now...

but I can't accept this PR, it changes almost 2K lines by breaking all the formating of the file so I don't know what is the actual change...

my guess it's #618

@ArthurHub ArthurHub closed this Oct 27, 2018
@PaulWoitaschek
Copy link

Thanks a lot!
There were multiple PR's open addressing this issue. I don't expect you to always keep this library update.
But after a major android update like P, really critical issues that need to be addressed asap arise.

Maybe put a warning on the readme, that this is currently unmaintained?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants