Skip to content

Conversation

@tibbi
Copy link
Contributor

@tibbi tibbi commented Apr 11, 2017

this should solve #197 . Flipping images other than 0, 90, 180 and 270 might not be perfect, but I see that those cases are quite glitchy in general.

@ArthurHub ArthurHub merged commit 3d31b8f into ArthurHub:master Apr 14, 2017
@ArthurHub
Copy link
Owner

awesome work, thank you!

@ArthurHub
Copy link
Owner

I have added couple of thinks to your work, will publish 2.4.0 soon:

  • fix flipping not working for image loaded by url (and sampled during loading)
  • handle rotation by 90 degrees to change horizontal/vertical flipping, otherwise the UX is strange
  • reset flip flags on reset of crop rectangle
  • support flipping CropImageActivity

Thanks again.

@tibbi
Copy link
Contributor Author

tibbi commented Apr 14, 2017

Sure, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants