Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: External IDs #55

Merged
merged 6 commits into from
Apr 8, 2024
Merged

API: External IDs #55

merged 6 commits into from
Apr 8, 2024

Conversation

Arthi-chaud
Copy link
Owner

@Arthi-chaud Arthi-chaud commented Apr 8, 2024

Closes #54

@Arthi-chaud Arthi-chaud added the api About the API label Apr 8, 2024
@Arthi-chaud Arthi-chaud self-assigned this Apr 8, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 92.82051% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 86.43%. Comparing base (cc69545) to head (418f4bf).

Files Patch % Lines
api/api/src/dto/external_id.rs 59.09% 9 Missing ⚠️
api/api/src/guards.rs 96.55% 2 Missing ⚠️
api/api/src/controllers/external_ids.rs 98.07% 1 Missing ⚠️
api/api/src/lib.rs 88.88% 1 Missing ⚠️
api/api/src/services/external_ids.rs 97.91% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #55      +/-   ##
==========================================
+ Coverage   85.83%   86.43%   +0.60%     
==========================================
  Files          35       38       +3     
  Lines        1955     2146     +191     
==========================================
+ Hits         1678     1855     +177     
- Misses        277      291      +14     
Flag Coverage Δ
api 86.43% <92.82%> (+0.60%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Arthi-chaud Arthi-chaud merged commit 411cbd9 into main Apr 8, 2024
12 checks passed
@Arthi-chaud Arthi-chaud deleted the api/external-ids branch April 8, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api About the API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API: External IDs
2 participants