-
Notifications
You must be signed in to change notification settings - Fork 0
Amucaj ft gzip fixes #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🌐 Web query:
httpx SUPPORTED_DECODERS public API zstd💡 Result:
In the httpx library, SUPPORTED_DECODERS is an internal dictionary defined in httpx/_decoders.py that maps Content-Encoding values to decoder classes. It includes "identity", "gzip", "deflate", and conditionally "br" (brotli) and "zstd" (Zstandard). The "zstd" entry is added by default but removed if the 'zstandard' package is not importable. This is not part of the public API. The public API automatically handles Content-Encoding decompression for supported formats when accessing response.content or response.text, without exposing SUPPORTED_DECODERS directly. Official docs do not list SUPPORTED_DECODERS as public. zstd support was added in httpx 0.27.1 (August 2024) via merged PR
#3139. Install with pip install 'httpx[zstd]' to include the zstandard dependency. Without it, servers using zstd Content-Encoding will fail decoding (gracefully skipped, but content remains compressed). Example from source: SUPPORTED_DECODERS = { "identity": IdentityDecoder, "gzip": GZipDecoder, "deflate": DeflateDecoder, "br": BrotliDecoder, "zstd": ZStandardDecoder, } if zstandard is None: SUPPORTED_DECODERS.pop("zstd")Citations:
🏁 Script executed:
Repository: ArtemisMucaj/jarvis
Length of output: 87
🏁 Script executed:
Repository: ArtemisMucaj/jarvis
Length of output: 780
🏁 Script executed:
Repository: ArtemisMucaj/jarvis
Length of output: 77
🏁 Script executed:
# Read the pyproject.toml to check zstandard dependency status cat pyproject.tomlRepository: ArtemisMucaj/jarvis
Length of output: 701
🏁 Script executed:
Repository: ArtemisMucaj/jarvis
Length of output: 301
🏁 Script executed:
Repository: ArtemisMucaj/jarvis
Length of output: 95
🏁 Script executed:
Repository: ArtemisMucaj/jarvis
Length of output: 45
Test silently passes when import fails — defeats its purpose.
Swallowing
ImportErrormeans that if httpx relocatesSUPPORTED_DECODERS(private_decodersmodule), the test passes without asserting zstd availability. Sincezstandard>=0.23is a hard runtime dependency, the check should be unconditional and explicit. Usepytest.importorskip("zstandard")to make the requirement explicit, then assert unconditionally.Additionally, this test taps httpx's private
_decodersmodule—consider asserting behavior via httpx's public API (e.g., decoding an actual zstd-encoded response) for better stability.🤖 Prompt for AI Agents