Skip to content
This repository has been archived by the owner on Apr 4, 2020. It is now read-only.

Add crypto_sign_ed25519_{sk,pk}_to_curve25519 #17

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add crypto_sign_ed25519_{sk,pk}_to_curve25519 #17

wants to merge 5 commits into from

Conversation

the-kenny
Copy link

This also includes a fix by @prook in #14 which crashes the Erlang VM in some error case.

ArteMisc
ArteMisc reviewed Jun 11, 2019
View reviewed changes
src/salty_nif.c Outdated Show resolved Hide resolved
@ArteMisc
Copy link
Owner

Thanks for the addition, could you review the comment? Will merge the PR after.

@the-kenny
Copy link
Author

@ArteMisc sure! The backslash was purely accidental. Fixed!

ArteMisc
ArteMisc reviewed Jun 11, 2019
View reviewed changes
src/salty_nif.c Outdated

SALTY_FUNC(crypto_sign_ed25519_sk_to_curve25519, 1) DO
SALTY_INPUT_BIN(0, sk_ed25519, crypto_sign_ed25519_PUBLICKEYBYTES);
\
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for this one here.

@the-kenny the-kenny force-pushed the add-ed-to-curve-conversion-functions branch from d04bfbe to a8d6bf4 Compare June 11, 2019 21:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ArteMisc ArteMisc ArteMisc left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@the-kenny @ArteMisc @prook