Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not prepend full build urls with jenkins base #50

Merged
merged 2 commits into from
Jul 26, 2022

Conversation

Artalus
Copy link
Owner

@Artalus Artalus commented Jul 24, 2022

fixes #49

@codecov
Copy link

codecov bot commented Jul 24, 2022

Codecov Report

Merging #50 (a6fd209) into master (4fddce8) will increase coverage by 1.82%.
The diff coverage is 71.87%.

@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
+ Coverage   16.35%   18.18%   +1.82%     
==========================================
  Files          14       15       +1     
  Lines         434      451      +17     
==========================================
+ Hits           71       82      +11     
- Misses        363      369       +6     
Flag Coverage Δ
integration 14.85% <25.00%> (+0.57%) ⬆️
unit 15.07% <71.87%> (+1.94%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/jenot/__init__.py 54.92% <33.33%> (-7.41%) ⬇️
src/jenot/url.py 86.95% <86.95%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fddce8...a6fd209. Read the comment docs.

@Artalus Artalus merged commit 2e6adc9 into master Jul 26, 2022
@Artalus Artalus deleted the issue/49-url-mismatch branch July 26, 2022 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pasting full url does not work if its domain differs from --jenkins_url
1 participant