Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Stripe accounts support #68

Open
erommel opened this issue Dec 14, 2018 · 4 comments
Open

Multiple Stripe accounts support #68

erommel opened this issue Dec 14, 2018 · 4 comments

Comments

@erommel
Copy link
Contributor

erommel commented Dec 14, 2018

Requested by user https://wordpress.org/support/topic/two-separate-stripe-accounts/

Can be added into core plugin as I don't think any other plugin has this feature.

@Arsenal21
Copy link
Owner

We can do an addon that adds the Stripe API keys option to the "Edit Stripe Products" interface. So for some products they can specify a different account where the payment for it will go to.

Similar to SWPM where for each payment button, they can enter API keys for it for an account.

@ozsolarwind
Copy link

I implemented this for a single product (but like the idea for multiple products) and for a specific usage which may not cater for every "path" through the plugin. I made changes to includes/class-asp-process-ipn-ng.php and includes/class-asp.php. The two patch files attached are for version 2.0.37. I use a Wordpress option value to identify the (one) product which as well as the stripe keys allows the Email Setting to personalized. I also use the 'asp_ng_pp_data_ready' filter to set the alternate stripe keys for the product (and 'asp_buyer_email_body', 'asp_buyer_email_subject', 'asp_seller_email_body' and 'asp_buyer_email_from' filters to personalize the email details).

Ideally, I'd like this to be implemented via filters to save having to re-apply my changes to new versions. I'm sure I haven't catered for all "paths" to set/change api keys so aren't yet comfortable to make a branch for this.

Kind regards

Angus
class-asp-process-ipn-ng.php.txt
class-asp.php.txt

@zcream
Copy link

zcream commented Dec 9, 2020

Another place where this is useful, if to allow a different stripe account for a different currency. Stripe allows multiple accounts in multiple currencies, and you can use these to save on currency conversion fees using transferwise or payoneer. So, the checkout can allow the user to select a different currency - and based on this choice the checkout will show a different stripe account.

Here is an example for woocommerce -

@erommel
Copy link
Contributor Author

erommel commented Dec 16, 2020

Thank you for your input, gentlemen!

This functionality has been added to current testing version, you can get it here https://s-plugins.com/testing-version/

Go to edit product page and look for it in the "Advanced Settings" section.

Please note this functionality is currently not supported by the add-ons. So if you're using Subscriptions, APM, Alipay, SOFORT and iDEAL add-ons - please do not enable this new option.

erommel added a commit that referenced this issue Jan 9, 2021
* Added 3D Secure check iframe

* Added trial support for variable subs

* Added 3D Secure iframe close button

* readme file updated for wp5.6

* Bumped version to 2.0.40t1

* Added `Disable 3D Secure Iframe` option

* Properly handle `succeeded` PI status after 3DS check

* Do not attempt to confirm `succeeded` PI

* Preliminary added per-product option to use other Stripe account #68

* Bumped version to 2.0.40t2

* Regenerated .pot file

* Fixed variations with negative price mod handling

* Fixed missing customer name and email when `Do Not Save Card Data on Stripe` option enabled

* Bumped version to 2.0.40t3

* Moved older changelog items to changelog.txt
Updated readme.txt

* Updated PUC library

Co-authored-by: amin0 <[email protected]>
erommel added a commit that referenced this issue Jan 12, 2021
* Dev 2.0.40 ti Dev 2.0.41 (#185)

* Added 3D Secure check iframe

* Added trial support for variable subs

* Added 3D Secure iframe close button

* readme file updated for wp5.6

* Bumped version to 2.0.40t1

* Added `Disable 3D Secure Iframe` option

* Properly handle `succeeded` PI status after 3DS check

* Do not attempt to confirm `succeeded` PI

* Preliminary added per-product option to use other Stripe account #68

* Bumped version to 2.0.40t2

* Regenerated .pot file

* Fixed variations with negative price mod handling

* Fixed missing customer name and email when `Do Not Save Card Data on Stripe` option enabled

* Bumped version to 2.0.40t3

* Moved older changelog items to changelog.txt
Updated readme.txt

* Updated PUC library

Co-authored-by: amin0 <[email protected]>

* Removed support of IE versions prior to 9 for payment popup

* Added jQuery UI Base theme

* Removed PUC library

* Preliminary added admin notice to install AUC plugin

* Updated AUC URL

* Bumped version to 2.0.41
Updated readme.txt

* Regenerated .pot file

Co-authored-by: amin0 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants