Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New API: compatibility with legacy API donation buttons #144

Open
erommel opened this issue Feb 25, 2020 · 2 comments
Open

New API: compatibility with legacy API donation buttons #144

erommel opened this issue Feb 25, 2020 · 2 comments

Comments

@erommel
Copy link
Contributor

erommel commented Feb 25, 2020

Several users asked for some solution to make their old donation buttons work as before when new Stripe API is used. In new API, amount input is located on payment popup button. So in order to enter donation amount, you first need to click donation button and then enter the amount. Old API had amount input displayed on the page instead of payment popup.

Switching to new API also breaks functionality of following donation buttons (example from customer's website):

34ca18

What can be done in this situation from our side: a new option can be added to product edit page, a checkbox "Show Amount Input on page" or something like that. When this option is enabled and product is donation product, plugin should display amount input on page. When the input is filled and "donate" button is clicked, it should display payment popup with prefilled amount.

Adding this option would allow users to choose whether they want amount input on page or on payment popup. This should also preserve functionality of similar self-made donation widgets (like the one on the screenshot).

@Arsenal21
Copy link
Owner

sounds good. How are they making that side by side donation amount thingy at the moment?

@erommel
Copy link
Contributor Author

erommel commented Feb 26, 2020

Using old API, it's quite simple. They just add those buttons and add onClick event listener on those. When clicked, it puts corresponding amount into the input provided by Stripe Payments. Stripe Payments handles the rest when payment button is clicked.

So we should do similar thing for new API to keep those custom-made widgets working.

erommel added a commit that referenced this issue Mar 4, 2020
* Fixed PHP notice. Closes #143

* Added additional items functionality for products

* Bumped version to 2.0.23t1

* Added "Last Name First" option
Closes #145

* Initial work on adding custom amount input #144

* Added support for Multi Currency addon (new API)

* More work on adding support for Multi Currency addon

* Fixed item price on checkout result was displayed impoperly for products with variations

* Bumped version to 2.0.23t2

* Fixed coupon discount amount on checkout result was displayed impoperly for products with variations

* Bumped version to 2.0.23t3

* Fixed COOKIEPATH and COOKIE_DOMAIN issue on multisite
Closes #146

* Removed unneeded 'use'

* Code refactor to better follow WP Coding Standards

* Made custom CSS textarea resizable horizontally

* More refactoring

* Bumped version to 2.0.23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants