optimising a bit

config.codekit

@@ -1,6 +1,6 @@
 {
 "CodeKitInfo": "This is a CodeKit 2.x project configuration file. It is designed to sync project settings across multiple machines. MODIFYING THE CONTENTS OF THIS FILE IS A POOR LIFE DECISION. If you do so, you will likely cause CodeKit to crash. This file is not useful unless accompanied by the project that created it in CodeKit 2. This file is not backwards-compatible with CodeKit 1.x. For more information, see: http:\/\/incident57.com\/codekit",
-"creatorBuild": "19076",
+"creatorBuild": "19099",
 "files": {
 	"\/bower.json": {
 		"fileType": 524288,
@@ -277,10 +277,18 @@
 			"active": 0,
 			"flagValue": -1
 			},
+		"no_nested_string_interpolation": {
+			"active": 1,
+			"flagValue": -1
+			},
 		"no_plusplus": {
 			"active": 0,
 			"flagValue": -1
 			},
+		"no_private_function_fat_arrows": {
+			"active": 1,
+			"flagValue": -1
+			},
 		"no_stand_alone_at": {
 			"active": 1,
 			"flagValue": -1
@@ -289,6 +297,10 @@
 			"active": 1,
 			"flagValue": -1
 			},
+		"no_this": {
+			"active": 0,
+			"flagValue": -1
+			},
 		"no_throwing_strings": {
 			"active": 1,
 			"flagValue": -1

src/js/unslider.js

@@ -59,8 +59,8 @@
 			//  Either set true/false, or an object with the HTML
 			//  elements for each arrow like below:
 			arrows: {
-				prev: '<a class="' + self._ + '-arrow prev">←</a>',
-				next: '<a class="' + self._ + '-arrow next">→</a>'
+				prev: '<a class="' + self._ + '-arrow prev">Prev</a>',
+				next: '<a class="' + self._ + '-arrow next">Next</a>'
 			},
 
 			//  How should Unslider animate?
@@ -135,7 +135,7 @@
 			});
 
 			//  Add swipe support
-			if(typeof jQuery.event.special.swipe !== undefined && self.options.swipe) {
+			if(jQuery.event.special.swipe && self.options.swipe) {
 				self.initSwipe();
 			}
 
@@ -380,10 +380,10 @@
 			self.current = Math.min(Math.max(0, to), self.total - 1);
 
 			if(self.options.nav) {
-				self.$nav.find('[data-slide="' + self.current + '"]')._toggleActive(self.options.activeClass);
+				self.$nav.find('[data-slide="' + self.current + '"]')._active(self.options.activeClass);
 			}
 
-			self.$slides.eq(self.current)._toggleActive(self.options.activeClass);
+			self.$slides.eq(self.current)._active(self.options.activeClass);
 
 			return self;
 		};
@@ -571,7 +571,7 @@
 	//  They're both just helpful types of shorthand for
 	//  anything that might take too long to write out or
 	//  something that might be used more than once.
-	$.fn._toggleActive = function(className) {
+	$.fn._active = function(className) {
 		return this.addClass(className).siblings().removeClass(className);
 	};
 
@@ -587,15 +587,8 @@
 	};
 
 	$.fn._move = function() {
-		var type = 'animate';
-
 		this.stop(true, true);
-
-		if($.fn.velocity) {
-			type = 'velocity';
-		}
-
-		return $.fn[type].apply(this, arguments);
+		return $.fn[$.fn.velocity ? 'velocity' : 'animate'].apply(this, arguments);
 	};
 
 	//  And set up our jQuery plugin
@@ -609,18 +602,10 @@
 			if(typeof opts === 'string' && $this.data('unslider')) {
 				opts = opts.split(':');
 
-				var fn = opts[0];
-				var call = $this.data('unslider')[fn];
+				var call = $this.data('unslider')[opts[0]];
 
 				//  Do we have arguments to pass to the string-function?
-				if(opts[1]) {
-					var args = opts[1].split(',');
-					return $.isFunction(call) && call.apply($this, args);
-				}
-
-				$.isFunction(call) && call();
-
-				return this;
+				$.isFunction(call) && call.apply($this, args ? null : opts[1].split(','));
 			}
 
 			return $this.data('unslider', new $.Unslider($this, opts));