Update AlifSemiconductors Pack Version #3
Conversation
Bugs/alif example fix
Add CameraCapture and fix github action
| push: | ||
| branches: [main] | ||
| schedule: | ||
| - cron: '30 22 28 * 0' |
There was a problem hiding this comment.
This would only run by schedule if day 28 of a month happens to be a Sunday.
| - cron: '30 22 28 * 0' | |
| - cron: '30 22 * * 0' |
| strategy: | ||
| fail-fast: true | ||
| matrix: | ||
| context: [object-detection.Debug+Alif-E7-M55-HP, object-detection.Debug+AVH-SSE-300-U55, kws.Debug+Alif-E7-M55-HE, kws.Debug+AVH-SSE-310-U65, kws.Debug+FRDM-K64F, kws.Debug+STM32F746-DISCO] |
There was a problem hiding this comment.
Any reason for not building the release contexts?
There was a problem hiding this comment.
No particular reason. Should I add both release and debug contexts?
| #endif // #if defined(__cplusplus) | ||
|
|
||
| #include "gpio.h" | ||
| #include "../src/gpio.h" |
There was a problem hiding this comment.
This looks pretty unusual. Header files placed into the src folder are typically considered "private" while ones in include folder represent the "public interface".
There was a problem hiding this comment.
One of the type definitions required in this file was not present in the pack's gpio.h and only in src/gpio.h. Would it better to remove the include and simply move the type definition into this file itself?
Co-authored-by: Jonatan Antoni <[email protected]> Signed-off-by: Atharva <[email protected]>
This PR:
1.0.0and updates all source files accordingly