Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Qidi Plus 4 #947

Closed
wants to merge 1 commit into from
Closed

Add Qidi Plus 4 #947

wants to merge 1 commit into from

Conversation

liberodark
Copy link

@liberodark liberodark commented Jan 30, 2025

The Goal of this PR is to try to upstream change for Qidi Plus 4.
For add Support of this printer.

More info is coming.

@Neko-vecter
Copy link

Neko-vecter commented Jan 30, 2025

You need to explain a bit more about what exactly this PR is for. “No description provided” is not acceptable.

Things need include:

  • Function of this PR / what this PR implement?
  • What change?
  • Demo of the change

If this PR / functions for a specific printer. I don't think adding it to main repo is a good idea.

@Neko-vecter
Copy link

The Goal of this PR is to try to upstream change for Qidi Plus 4. For add Support of this printer.

I don't think the printer specific function PR in to the main repo (mainstream) is a good idea. Since only that printer using this function.
It should be implement in your own repo (fork).

@liberodark
Copy link
Author

Yep but probably a part would be upstream.

@Neko-vecter
Copy link

Neko-vecter commented Jan 30, 2025

Yep but probably a part would be upstream.

If a PR relate to a specific function of specific printer. That mean the printer require a specific repo to implement. The mainstream only focus the function that every device require.

I think they have a fork? If they don't and you want using the latest features. You should using your own repo to implement. If you add this into mainstream that main every printer using mainstream has this features.

@liberodark
Copy link
Author

liberodark commented Jan 30, 2025

Ok im go to use my fork.

@liberodark liberodark closed this Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants