fix: Add support for litellm Message type #1308
Conversation
dosubot
bot
added
the
size:M
nate-mar
changed the title
nate-mar
force-pushed
the
handle-litellm-message-type-for-input-message
branch
from
7746e54 to
8d59d77
Compare
nate-mar
force-pushed
the
handle-litellm-message-type-for-input-message
branch
from
8d59d77 to
7efda1e
Compare
Add support for litellm Message type
nate-mar
force-pushed
the
handle-litellm-message-type-for-input-message
branch
from
7efda1e to
208ef0f
Compare
|
resolves #1303 |
| from litellm.types.utils import ( | ||
| Message as LitellmMessage, | ||
| ) |
There was a problem hiding this comment.
Why split the import here? it seems identical to the import above?
There was a problem hiding this comment.
Oops, you're right.
| if messages_as_dicts: | ||
| _set_span_attribute(span, SpanAttributes.INPUT_VALUE, json.dumps(messages_as_dicts)) |
There was a problem hiding this comment.
Not blocking but this makes the input a duplicate of the messages - bloating the payload. I sorta question whether we should continue to do this...
In any case if set to a JSON dumps I would set the MIME_TYPE here.
There was a problem hiding this comment.
Yeah, it does. Happy to discontinue here, though not sure if anyone is specifically relying on it right now.
There was a problem hiding this comment.
I'm just going to move forward with this PR for now. Let's table whether we discontinue this practice across other instruments as well and discuss it later.
I'll add the MIME_TYPE.
Add support for litellm Message type