Skip to content

test(visual): fail loud on cold-start across Pdf*Tests (#957 residu ii) #966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsboige merged 1 commit into from
Jul 30, 2026
Merged

test(visual): fail loud on cold-start across Pdf*Tests (#957 residu ii) #966

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 24 additions & 23 deletions Generation/Converters/Argumentum.AssetConverter.VisualTests/PdfContentTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ namespace Argumentum.AssetConverter.VisualTests
/// (TarotCards/PokerCards) or uses font encodings without ToUnicode mappings
/// (FallaciesWeb). Structural checks catch the same regressions (empty cards,
/// broken generation) more reliably.
/// Tests pass silently if Target/ doesn't exist (CI cold-start).
/// Fails LOUD if Target/ doesn't exist (#957 residu ii) — was a silent faux-vert (pass-on-nothing).
/// </summary>
public class PdfContentTests : IDisposable
{
Expand All @@ -38,14 +38,15 @@ public void Dispose() { }
private static string GetPdfDir(string lang) =>
Path.Combine(TargetRoot, lang, "Documents", "density-0");

private bool EnsureTarget()
private void EnsureTarget()
{
// #957 residu ii: cold-start faux-vert. A missing Target/ must FAIL LOUD, not pass silently —
// these tests verify generated PDFs and assert nothing without them. Assert.Fail is a subtraction
// (removes the silent `return;`), not a counterweight: no [Fact(Skip)] (static, would kill the
// tests where they work), no continue-on-error. VisualTests is NOT run by CI (build.yml targets
// only Argumentum.AssetConverter.Tests.csproj), so this fails locally, not in the release gate.
if (!Directory.Exists(TargetRoot))
{
_output.WriteLine("Skipped: Target/ not found — run pipeline first");
return false;
}
return true;
Assert.Fail("PdfContentTests require a generated Target/ — run the pipeline first (bin/Debug/net9.0-windows/Target not found). This test verified nothing.");
}

// --- File size sanity checks ---
Expand All @@ -57,11 +58,11 @@ private bool EnsureTarget()
[InlineData("pt")]
public void All_Pdfs_Have_Minimum_Size(string lang)
{
if (!EnsureTarget()) return;
EnsureTarget();
var dir = GetPdfDir(lang);
if (!Directory.Exists(dir)) return;
if (!Directory.Exists(dir)) Assert.Fail($"Language directory not found: {dir} — test verified nothing (Target/ exists but this language produced no Documents/density-0/; check pipeline output).");
var pdfs = Directory.GetFiles(dir, "*.pdf");
if (pdfs.Length == 0) return;
if (pdfs.Length == 0) Assert.Fail($"No PDFs found for {lang} in Target/ — test verified nothing (check pipeline output).");

var failures = new List<string>();
foreach (var pdf in pdfs)
Expand All @@ -80,7 +81,7 @@ public void All_Pdfs_Have_Minimum_Size(string lang)
[Fact]
public void A0_Pdf_Sizes_Are_Consistent_Across_Languages()
{
if (!EnsureTarget()) return;
EnsureTarget();

var sizes = new Dictionary<string, long>();
foreach (var lang in Languages)
Expand All @@ -90,7 +91,7 @@ public void A0_Pdf_Sizes_Are_Consistent_Across_Languages()
sizes[lang] = new FileInfo(pdfs[0]).Length;
}

if (sizes.Count < 2) return;
if (sizes.Count < 2) Assert.Fail($"Only {sizes.Count} language(s) with A0 PDFs found in Target/ — test verified nothing (expected >= 2 languages to compare; check pipeline output for missing languages).");

var avgSize = sizes.Values.Average();
var minSize = sizes.Values.Min();
Expand All @@ -117,13 +118,13 @@ public void A0_Pdf_Sizes_Are_Consistent_Across_Languages()
[InlineData("pt")]
public void FallaciesWeb_A4_Has_Reasonable_Page_Count(string lang)
{
if (!EnsureTarget()) return;
EnsureTarget();
var dir = GetPdfDir(lang);
if (!Directory.Exists(dir)) return;
if (!Directory.Exists(dir)) Assert.Fail($"Language directory not found: {dir} — test verified nothing (Target/ exists but this language produced no Documents/density-0/; check pipeline output).");
var pdfs = Directory.GetFiles(dir, "*_Fallacies_Web_A4_*.pdf")
.Where(p => !Path.GetFileName(p).Contains("Thumbnails"))
.ToArray();
if (pdfs.Length == 0) return;
if (pdfs.Length == 0) Assert.Fail($"No PDFs found for {lang} in Target/ — test verified nothing (check pipeline output).");

foreach (var pdf in pdfs)
{
Expand All @@ -145,16 +146,16 @@ public void FallaciesWeb_A4_Has_Reasonable_Page_Count(string lang)
[InlineData("pt")]
public void TarotCards_Has_Multiple_Pages(string lang)
{
if (!EnsureTarget()) return;
EnsureTarget();
var dir = GetPdfDir(lang);
if (!Directory.Exists(dir)) return;
if (!Directory.Exists(dir)) Assert.Fail($"Language directory not found: {dir} — test verified nothing (Target/ exists but this language produced no Documents/density-0/; check pipeline output).");
// Main TarotCards PDF (not split, not FacesOnly, not Virtues)
var pdf = Directory.GetFiles(dir, "Argumentum_TarotCards_*.pdf")
.FirstOrDefault(p => !Path.GetFileName(p).Contains("-")
&& !Path.GetFileName(p).Contains("Virtues")
&& !Path.GetFileName(p).Contains("FacesOnly")
&& !Path.GetFileName(p).Contains("Print"));
if (pdf == null) return;
if (pdf == null) Assert.Fail($"No matching PDF found for {lang} in Target/ — test verified nothing (Target/ exists but the expected CardSet PDF is missing; check pipeline output).");

using var doc = PdfDocument.Open(pdf);
var pages = doc.NumberOfPages;
Expand All @@ -172,14 +173,14 @@ public void TarotCards_Has_Multiple_Pages(string lang)
[InlineData("pt")]
public void PokerCards_Has_Multiple_Pages(string lang)
{
if (!EnsureTarget()) return;
EnsureTarget();
var dir = GetPdfDir(lang);
if (!Directory.Exists(dir)) return;
if (!Directory.Exists(dir)) Assert.Fail($"Language directory not found: {dir} — test verified nothing (Target/ exists but this language produced no Documents/density-0/; check pipeline output).");
// Main PokerCards PDF (not split, not Print&Play)
var pdf = Directory.GetFiles(dir, "Argumentum_PokerCards_*.pdf")
.FirstOrDefault(p => !Path.GetFileName(p).Contains("-")
&& !Path.GetFileName(p).Contains("Print"));
if (pdf == null) return;
if (pdf == null) Assert.Fail($"No matching PDF found for {lang} in Target/ — test verified nothing (Target/ exists but the expected CardSet PDF is missing; check pipeline output).");

using var doc = PdfDocument.Open(pdf);
var pages = doc.NumberOfPages;
Expand All @@ -197,9 +198,9 @@ public void PokerCards_Has_Multiple_Pages(string lang)
[InlineData("pt")]
public void Each_Language_Has_Multiple_Pdf_Types(string lang)
{
if (!EnsureTarget()) return;
EnsureTarget();
var dir = GetPdfDir(lang);
if (!Directory.Exists(dir)) return;
if (!Directory.Exists(dir)) Assert.Fail($"Language directory not found: {dir} — test verified nothing (Target/ exists but this language produced no Documents/density-0/; check pipeline output).");
var pdfs = Directory.GetFiles(dir, "*.pdf");

// Each language should have at least: A0, A4, Thumbnails, Print&Play,
Expand Down
51 changes: 26 additions & 25 deletions Generation/Converters/Argumentum.AssetConverter.VisualTests/PdfDimensionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ namespace Argumentum.AssetConverter.VisualTests
/// <summary>
/// Stage 1 of #212: PDF dimension and page count regression tests.
/// Validates that generated PDFs have correct page sizes and reasonable page counts.
/// Tests pass silently if Target/ doesn't exist (CI cold-start).
/// Fails LOUD if Target/ doesn't exist (#957 residu ii) — was a silent faux-vert (pass-on-nothing).
/// </summary>
public class PdfDimensionTests : IDisposable
{
Expand Down Expand Up @@ -52,14 +52,15 @@ private static int GetPageCount(string pdfPath)
return doc.NumberOfPages;
}

private bool EnsureTarget()
private void EnsureTarget()
{
// #957 residu ii: cold-start faux-vert. A missing Target/ must FAIL LOUD, not pass silently —
// these tests verify generated PDFs and assert nothing without them. Assert.Fail is a subtraction
// (removes the silent `return;`), not a counterweight: no [Fact(Skip)] (static, would kill the
// tests where they work), no continue-on-error. VisualTests is NOT run by CI (build.yml targets
// only Argumentum.AssetConverter.Tests.csproj), so this fails locally, not in the release gate.
if (!Directory.Exists(TargetRoot))
{
_output.WriteLine("Skipped: Target/ not found — run pipeline first");
return false;
}
return true;
Assert.Fail("PdfDimensionTests require a generated Target/ — run the pipeline first (bin/Debug/net9.0-windows/Target not found). This test verified nothing.");
}

// --- A0 Format Tests ---
Expand All @@ -71,9 +72,9 @@ private bool EnsureTarget()
[InlineData("pt")]
public void A0_Pdf_Has_Correct_Dimensions(string lang)
{
if (!EnsureTarget()) return;
EnsureTarget();
var pdfs = GetPdfs(lang, "*_A0_*.pdf").ToList();
if (pdfs.Count == 0) { _output.WriteLine($"No A0 PDFs for {lang}"); return; }
if (pdfs.Count == 0) Assert.Fail($"No A0 PDFs for {lang} in Target/ — test verified nothing (check pipeline output).");

foreach (var pdf in pdfs)
{
Expand All @@ -91,9 +92,9 @@ public void A0_Pdf_Has_Correct_Dimensions(string lang)
[InlineData("pt")]
public void A0_Pdf_Has_Exactly_One_Page(string lang)
{
if (!EnsureTarget()) return;
EnsureTarget();
var pdfs = GetPdfs(lang, "*_A0_*.pdf").ToList();
if (pdfs.Count == 0) return;
if (pdfs.Count == 0) Assert.Fail($"No matching PDFs found for {lang} in Target/ — test verified nothing (Target/ exists but this CardSet pattern produced no files; check pipeline output).");

foreach (var pdf in pdfs)
Assert.Equal(1, GetPageCount(pdf));
Expand All @@ -108,9 +109,9 @@ public void A0_Pdf_Has_Exactly_One_Page(string lang)
[InlineData("pt")]
public void A4_Pdf_Has_Correct_Dimensions(string lang)
{
if (!EnsureTarget()) return;
EnsureTarget();
var pdfs = GetPdfs(lang, "*_A4_*.pdf").ToList();
if (pdfs.Count == 0) { _output.WriteLine($"No A4 PDFs for {lang}"); return; }
if (pdfs.Count == 0) Assert.Fail($"No A4 PDFs for {lang} in Target/ — test verified nothing (check pipeline output).");

foreach (var pdf in pdfs)
{
Expand All @@ -128,9 +129,9 @@ public void A4_Pdf_Has_Correct_Dimensions(string lang)
[InlineData("pt")]
public void A4_Pdf_Has_At_Least_One_Page(string lang)
{
if (!EnsureTarget()) return;
EnsureTarget();
var pdfs = GetPdfs(lang, "*_A4_*.pdf").ToList();
if (pdfs.Count == 0) return;
if (pdfs.Count == 0) Assert.Fail($"No matching PDFs found for {lang} in Target/ — test verified nothing (Target/ exists but this CardSet pattern produced no files; check pipeline output).");

foreach (var pdf in pdfs)
Assert.True(GetPageCount(pdf) >= 1, $"{Path.GetFileName(pdf)} has 0 pages");
Expand All @@ -145,9 +146,9 @@ public void A4_Pdf_Has_At_Least_One_Page(string lang)
[InlineData("pt")]
public void PrintAndPlay_Pdf_Is_A4_Format(string lang)
{
if (!EnsureTarget()) return;
EnsureTarget();
var pdfs = GetPdfs(lang, "*_Print&Play_*.pdf").ToList();
if (pdfs.Count == 0) return;
if (pdfs.Count == 0) Assert.Fail($"No matching PDFs found for {lang} in Target/ — test verified nothing (Target/ exists but this CardSet pattern produced no files; check pipeline output).");

foreach (var pdf in pdfs)
{
Expand All @@ -167,11 +168,11 @@ public void PrintAndPlay_Pdf_Is_A4_Format(string lang)
[InlineData("pt")]
public void All_Pdfs_Have_NonZero_Pages(string lang)
{
if (!EnsureTarget()) return;
EnsureTarget();
var dir = GetPdfDir(lang);
if (!Directory.Exists(dir)) return;
if (!Directory.Exists(dir)) Assert.Fail($"Language directory not found: {dir} — test verified nothing (Target/ exists but this language produced no Documents/density-0/; check pipeline output).");
var pdfs = Directory.GetFiles(dir, "*.pdf");
if (pdfs.Length == 0) return;
if (pdfs.Length == 0) Assert.Fail($"No PDFs at all for {lang} in {dir} — test verified nothing.");

foreach (var pdf in pdfs)
Assert.True(GetPageCount(pdf) > 0, $"{Path.GetFileName(pdf)} has 0 pages");
Expand All @@ -182,7 +183,7 @@ public void All_Pdfs_Have_NonZero_Pages(string lang)
[Fact]
public void All_Languages_Have_FallaciesWeb_A0()
{
if (!EnsureTarget()) return;
EnsureTarget();
foreach (var lang in Languages)
{
var pdfs = GetPdfs(lang, "*_Fallacies_Web_A0_*.pdf").ToList();
Expand All @@ -194,7 +195,7 @@ public void All_Languages_Have_FallaciesWeb_A0()
[Fact]
public void All_Languages_Have_FallaciesWeb_A4()
{
if (!EnsureTarget()) return;
EnsureTarget();
foreach (var lang in Languages)
{
var pdfs = GetPdfs(lang, "*_Fallacies_Web_A4_*.pdf").ToList();
Expand All @@ -205,7 +206,7 @@ public void All_Languages_Have_FallaciesWeb_A4()
[Fact]
public void All_Languages_Have_TarotCards()
{
if (!EnsureTarget()) return;
EnsureTarget();
foreach (var lang in Languages)
{
var pdfs = GetPdfs(lang, "*_TarotCards_*.pdf")
Expand All @@ -219,7 +220,7 @@ public void All_Languages_Have_TarotCards()
[Fact]
public void All_Languages_Have_PokerCards()
{
if (!EnsureTarget()) return;
EnsureTarget();
foreach (var lang in Languages)
{
var pdfs = GetPdfs(lang, "*_PokerCards_*.pdf").ToList();
Expand All @@ -231,7 +232,7 @@ public void All_Languages_Have_PokerCards()
[Fact]
public void All_Languages_Have_PrintAndPlay()
{
if (!EnsureTarget()) return;
EnsureTarget();
foreach (var lang in Languages)
{
var pdfs = GetPdfs(lang, "*_Print&Play_*.pdf").ToList();
Expand Down
27 changes: 14 additions & 13 deletions Generation/Converters/Argumentum.AssetConverter.VisualTests/PdfSnapshotTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ namespace Argumentum.AssetConverter.VisualTests
/// <summary>
/// Stage 2 of #212: PDF structural regression via Verify snapshot comparison.
/// Captures page dimensions, page count, text length, and letter count.
/// Tests pass silently if Target/ doesn't exist (CI cold-start).
/// Fails LOUD if Target/ doesn't exist (#957 residu ii) — was a silent faux-vert (pass-on-nothing).
/// </summary>
public class PdfSnapshotTests : IDisposable
{
Expand All @@ -30,14 +30,15 @@ public void Dispose() { }
private static string GetPdfPath(string lang, string filename) =>
Path.Combine(TargetRoot, lang, "Documents", "density-0", filename);

private bool EnsureTarget()
private void EnsureTarget()
{
// #957 residu ii: cold-start faux-vert. A missing Target/ must FAIL LOUD, not pass silently —
// these tests verify generated PDFs and assert nothing without them. Assert.Fail is a subtraction
// (removes the silent `return;`), not a counterweight: no [Fact(Skip)] (static, would kill the
// tests where they work), no continue-on-error. VisualTests is NOT run by CI (build.yml targets
// only Argumentum.AssetConverter.Tests.csproj), so this fails locally, not in the release gate.
if (!Directory.Exists(TargetRoot))
{
_output.WriteLine("Skipped: Target/ not found — run pipeline first");
return false;
}
return true;
Assert.Fail("PdfSnapshotTests require a generated Target/ — run the pipeline first (bin/Debug/net9.0-windows/Target not found). This test verified nothing.");
}

// --- FallaciesWeb A4 (all languages) ---
Expand All @@ -49,10 +50,10 @@ private bool EnsureTarget()
[InlineData("pt")]
public async Task FallaciesWeb_A4_FirstPage_Structure(string lang)
{
if (!EnsureTarget()) return;
EnsureTarget();

var pdfPath = GetPdfPath(lang, $"Argumentum_Fallacies_Web_A4_{lang}.pdf");
if (!File.Exists(pdfPath)) { _output.WriteLine($"PDF not found: {pdfPath}"); return; }
if (!File.Exists(pdfPath)) Assert.Fail($"Expected PDF not found: {pdfPath} — Target/ exists but this file is missing (test verified nothing; check harvest/pipeline output).");

using var doc = PdfDocument.Open(pdfPath);
var page = doc.GetPage(1);
Expand Down Expand Up @@ -82,10 +83,10 @@ public async Task FallaciesWeb_A4_FirstPage_Structure(string lang)
[InlineData("pt")]
public async Task TarotCards_FirstPage_Structure(string lang)
{
if (!EnsureTarget()) return;
EnsureTarget();

var pdfPath = GetPdfPath(lang, $"Argumentum_TarotCards_{lang}.pdf");
if (!File.Exists(pdfPath)) { _output.WriteLine($"PDF not found: {pdfPath}"); return; }
if (!File.Exists(pdfPath)) Assert.Fail($"Expected PDF not found: {pdfPath} — Target/ exists but this file is missing (test verified nothing; check harvest/pipeline output).");

using var doc = PdfDocument.Open(pdfPath);
var page = doc.GetPage(1);
Expand Down Expand Up @@ -113,10 +114,10 @@ public async Task TarotCards_FirstPage_Structure(string lang)
[InlineData("pt")]
public async Task PokerCards_FirstPage_Structure(string lang)
{
if (!EnsureTarget()) return;
EnsureTarget();

var pdfPath = GetPdfPath(lang, $"Argumentum_PokerCards_{lang}.pdf");
if (!File.Exists(pdfPath)) { _output.WriteLine($"PDF not found: {pdfPath}"); return; }
if (!File.Exists(pdfPath)) Assert.Fail($"Expected PDF not found: {pdfPath} — Target/ exists but this file is missing (test verified nothing; check harvest/pipeline output).");

using var doc = PdfDocument.Open(pdfPath);
var page = doc.GetPage(1);
Expand Down
Loading