docs(licensing): #905 §7.1 RESOLVED — the last flagged item is closed on master (#955) - #956
Merged
Merged
Conversation
… on master (#955) The inventory still told jsboige to arbitrate FluentAssertions, and still named 7.2.0 as the last Apache-2.0 release. Both are now false on master: the arbitration was made (downgrade) and #955 (6d0bfda) implemented it at 7.2.2. Five stale references rectified (headline, §3 table, §5, §7.1, §8), following the RESOLVED pattern §7.2 already established in this file for PdfPig. Measured firsthand on the restored nuspecs (2026-07-27), not taken on faith: 7.2.2 license type="expression" -> Apache-2.0, licenseUrl licenses.nuget.org 8.5.0 license type="file" -> LICENSE, licenseUrl aka.ms/deprecate... and two details the PR body did not cite: - <authors> gains "Xceed" at 8.x: the takeover is legible in the authorship line, not only in the licence field; - requireLicenseAcceptance is ABSENT in 7.2.2 (NuGet default false), against true in 8.5.0 - "absent" is not "declared false", and on a licence document that distinction is the whole point. The §8 claim is scoped to the surface this audit covers (24 direct deps of the shipping binary + transitive closure, and the test project's direct deps), rather than asserting a universal over the whole repo. Docs only. 0 prod-CSV write, 0 OWL path touched. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This was referenced Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Rectify five stale references to
FluentAssertionsin the licence inventory. After #955 (6d0bfda9) the document is wrong about master in two independent ways:This is the
#905 §7.1flag-removal that was part of #955's DoD and did not fit in a dependency PR.Why it matters more than a docs tidy
docs/licensing/dependency-license-inventory.mdis the release licence gate. It is the artefact presented at v0.9.0 to show the gate is met. A gate document that lists an open arbitration reads as "one thing still unresolved" to whoever reviews it — when in fact nothing is.Measured firsthand, not taken on faith
The bot review on #955 explicitly scoped out re-fetching the nuspecs ("did not independently re-fetch … the direction is not in doubt"). Since the whole PR rests on that claim, I measured it:
<license><licenseUrl><authors>requireLicenseAcceptancetype="expression"→Apache-2.0licenses.nuget.org/Apache-2.0type="file"→LICENSEaka.ms/deprecateLicenseUrltrueTwo details neither #955 nor its review cited:
<authors>gainsXceedat 8.x. The commercial takeover is legible in the authorship line, not only in the licence field — a second, independent signal for the same event.requireLicenseAcceptanceis absent in 7.2.2, not declaredfalse. NuGet's default isfalse, so the effect is the same — but on a licence document "absent" and "declared false" are not interchangeable, and I corrected my own first wording of this line before committing.Changes
Five call-sites, following the RESOLVED pattern §7.2 already established in this same file for the PdfPig swap (keep the original finding as the audit record, prepend a dated resolution block):
8.5.0 | commercial (Xceed) — FLAG §7.1→7.2.2 | Apache-2.0requireLicenseAcceptancepackages (with the measured nuance above)downgrademarked CHOSEN and the 7.2.0→7.2.2 figure corrected in placeScope discipline
The §8 claim is deliberately bounded to what this audit measured — the 24 direct deps of the shipping binary plus their transitive closure (§1/§2), and the test project's direct deps (§3) — rather than asserting a universal over the whole repository. The audit never enumerated, say, vendored npm trees; the document should not imply it did.
Docs only. 0 prod-CSV write, 0 OWL path touched (publication-safe, #133). No code, no config.