Skip to content

fix(ci): #909 make the Test step actually run tests (Tests.csproj was missing from the .sln) #911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsboige merged 2 commits into from
Jul 26, 2026
Merged

fix(ci): #909 make the Test step actually run tests (Tests.csproj was missing from the .sln) #911

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e9600a
fix(ci): #909 make the Test step actually run tests (Tests.csproj was…
Jul 25, 2026
e7470d0
fix(tests): make GetEnabled_is_release_only_by_default deterministic …
Jul 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,13 @@ jobs:
run: dotnet build "Argumentum Converters.sln" --no-restore -c ${{ matrix.configuration }}

- name: Test
run: dotnet test "Generation/Converters/Argumentum.AssetConverter.Tests/Argumentum.AssetConverter.Tests.csproj" --no-build -c ${{ matrix.configuration }} --verbosity normal
# #909: the Test step was a silent no-op — Argumentum.AssetConverter.Tests.csproj was NOT in
# Argumentum Converters.sln, so the Build step never built it, and `--no-build` then found no
# assembly and exited 0 having run zero tests. Two fixes, both needed:
# (1) Tests.csproj is now in the .sln (Restore/Build cover it, and the #587 NuGet audit now
# scans test deps too — FluentAssertions, Playwright, xunit).
# (2) `--no-build` dropped so the step is self-sufficient: if Tests is ever not built upstream,
# `dotnet test` builds it (loud failure on error) instead of silently no-op'ing.
# Browser tests (HtmlToPngConverterTests, PdfAssemblerTests) self-install chromium in-test via
# Microsoft.Playwright.Program.Main("install","chromium"); no separate install step needed.
run: dotnet test "Generation/Converters/Argumentum.AssetConverter.Tests/Argumentum.AssetConverter.Tests.csproj" -c ${{ matrix.configuration }} --verbosity normal
15 changes: 15 additions & 0 deletions Argumentum Converters.sln
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,8 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Converters", "Converters",
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Argumentum.AssetConverter.VisualTests", "Generation\Converters\Argumentum.AssetConverter.VisualTests\Argumentum.AssetConverter.VisualTests.csproj", "{F777878A-1E32-4393-9CB1-1D7F98965DEE}"
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Argumentum.AssetConverter.Tests", "Generation\Converters\Argumentum.AssetConverter.Tests\Argumentum.AssetConverter.Tests.csproj", "{C712CED0-1E3F-41B5-8D99-15CFB7CD9513}"
EndProject
Global
GlobalSection(SolutionConfigurationPlatforms) = preSolution
Debug|Any CPU = Debug|Any CPU
Expand Down Expand Up @@ -84,6 +86,18 @@ Global
{F777878A-1E32-4393-9CB1-1D7F98965DEE}.Release|x64.Build.0 = Release|Any CPU
{F777878A-1E32-4393-9CB1-1D7F98965DEE}.Release|x86.ActiveCfg = Release|Any CPU
{F777878A-1E32-4393-9CB1-1D7F98965DEE}.Release|x86.Build.0 = Release|Any CPU
{C712CED0-1E3F-41B5-8D99-15CFB7CD9513}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{C712CED0-1E3F-41B5-8D99-15CFB7CD9513}.Debug|Any CPU.Build.0 = Debug|Any CPU
{C712CED0-1E3F-41B5-8D99-15CFB7CD9513}.Debug|x64.ActiveCfg = Debug|Any CPU
{C712CED0-1E3F-41B5-8D99-15CFB7CD9513}.Debug|x64.Build.0 = Debug|Any CPU
{C712CED0-1E3F-41B5-8D99-15CFB7CD9513}.Debug|x86.ActiveCfg = Debug|Any CPU
{C712CED0-1E3F-41B5-8D99-15CFB7CD9513}.Debug|x86.Build.0 = Debug|Any CPU
{C712CED0-1E3F-41B5-8D99-15CFB7CD9513}.Release|Any CPU.ActiveCfg = Release|Any CPU
{C712CED0-1E3F-41B5-8D99-15CFB7CD9513}.Release|Any CPU.Build.0 = Release|Any CPU
{C712CED0-1E3F-41B5-8D99-15CFB7CD9513}.Release|x64.ActiveCfg = Release|Any CPU
{C712CED0-1E3F-41B5-8D99-15CFB7CD9513}.Release|x64.Build.0 = Release|Any CPU
{C712CED0-1E3F-41B5-8D99-15CFB7CD9513}.Release|x86.ActiveCfg = Release|Any CPU
{C712CED0-1E3F-41B5-8D99-15CFB7CD9513}.Release|x86.Build.0 = Release|Any CPU
EndGlobalSection
GlobalSection(SolutionProperties) = preSolution
HideSolutionNode = FALSE
Expand All @@ -96,6 +110,7 @@ Global
{1A7077BC-7CA9-4D76-9D96-C674564283F9} = {A3188815-F9CE-4FAD-8E43-3D216DA51E5D}
{22204A79-A715-187C-1CCC-42730285228E} = {36912121-518A-D096-DAD0-E6C5A9AF61AB}
{F777878A-1E32-4393-9CB1-1D7F98965DEE} = {22204A79-A715-187C-1CCC-42730285228E}
{C712CED0-1E3F-41B5-8D99-15CFB7CD9513} = {22204A79-A715-187C-1CCC-42730285228E}
EndGlobalSection
GlobalSection(ExtensibilityGlobals) = postSolution
SolutionGuid = {C0667D66-974C-44D8-AAF8-3DB41AADBBF5}
Expand Down
Loading