Skip to content

test(tests): warning-zero follow-on #710 — clear 3 xUnit analyzer warnings (5czj9v [2]) #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsboige merged 1 commit into from
Jul 6, 2026
Merged

test(tests): warning-zero follow-on #710 — clear 3 xUnit analyzer warnings (5czj9v [2]) #736

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Generation/Converters/Argumentum.AssetConverter.Tests/Ontology/OwlAdapterRegressionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,7 @@ public void DocumentConcept_Unknown_Type_Throws()
}

[Fact]
public void ToFileAsync_Writes_A_Non_Empty_OWL2XML_File()
public async Task ToFileAsync_Writes_A_Non_Empty_OWL2XML_File()
{
// Serialization works end-to-end (this is why #133 ships a non-empty ontology despite
// the readers being broken — the graph is correctly built, only self-retrieval fails).
Expand All @@ -316,7 +316,7 @@ public void ToFileAsync_Writes_A_Non_Empty_OWL2XML_File()
var tempPath = Path.Combine(Path.GetTempPath(), $"arg_onto_test_{Guid.NewGuid():N}.owl");
try
{
adapter.ToFileAsync(OWLSharp.OWLEnums.OWLFormats.OWL2XML, tempPath).Wait();
await adapter.ToFileAsync(OWLSharp.OWLEnums.OWLFormats.OWL2XML, tempPath);
File.Exists(tempPath).Should().BeTrue();
var content = File.ReadAllText(tempPath);
content.Should().NotBeNullOrEmpty("the serialized ontology must be non-empty");
Expand Down
2 changes: 1 addition & 1 deletion ...rgumentum.AssetConverter.Tests/WebBasedGenerator/HarvestManagerExpectedImageCountTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ public class HarvestManagerExpectedImageCountTests
[InlineData(10, 3, "BUNCH", 10)] // case-sensitive: CardPen rsstyle is lowercase; "BUNCH" does NOT group
[InlineData(10, 3, "Bunch", 10)] // case-sensitive: mixed-case does NOT group either
public void ComputeExpectedImageCount_MirrorsCardPenGrouping(
int cardCount, int rscount, string rsstyle, int expected)
int cardCount, int rscount, string? rsstyle, int expected)
{
HarvestManager.ComputeExpectedImageCount(cardCount, rscount, rsstyle)
.Should().Be(expected,
Expand Down
2 changes: 1 addition & 1 deletion ...rters/Argumentum.AssetConverter.Tests/WebBasedGenerator/LocalizedFileNameContractTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public class LocalizedFileNameContractTests
[Theory]
[InlineData(null)]
[InlineData("")]
public void EmptyOrNull_ReturnedAsIs(string fileName)
public void EmptyOrNull_ReturnedAsIs(string? fileName)
{
// The first guard returns the input verbatim, so no language substitution is attempted.
CardSetLocalization.GetLocalizedFileName(fileName, "fr", "en")
Expand Down
Loading