Skip to content

test(tests): nullable-cleanup Slice C-3 — MindmapGeneration SVG cluster (#710, x0ykyn) #731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsboige merged 1 commit into from
Jul 6, 2026
Merged

test(tests): nullable-cleanup Slice C-3 — MindmapGeneration SVG cluster (#710, x0ykyn) #731

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...erters/Argumentum.AssetConverter.Tests/MindmapGeneration/SvgConversionIntegrationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,8 @@ public void TryAutomateSvgConversion_WithValidMmFile_ShouldReturnTrueAndCreateSv

// Act
var method = typeof(FallacyMindMapDocumentConfig).GetMethod("TryAutomateSvgConversion", BindingFlags.NonPublic | BindingFlags.Instance, null, new[] { typeof(string), typeof(string), typeof(AssetConverterConfig), typeof(bool) }, null);
var result = (bool)method.Invoke(_generator, new object[] { mmPath, svgPath, _config, false });
Assert.NotNull(method);
var result = (bool)method!.Invoke(_generator, new object[] { mmPath, svgPath, _config, false })!;

// Assert
Assert.True(result, "L'exécution du processus de conversion SVG doit réussir.");
Expand Down
2 changes: 1 addition & 1 deletion ...rters/Argumentum.AssetConverter.Tests/MindmapGeneration/SvgDisambiguationContractTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ public class SvgDisambiguationContractTests
private static readonly XNamespace Svg = "http://www.w3.org/2000/svg";

// Minimal <g> with one <text> child — the shape CollectPossibleSvgNodes scans for.
private static XElement G(string text, string id = null)
private static XElement G(string text, string? id = null)
{
var g = new XElement(Svg + "g");
if (id != null) g.SetAttributeValue("id", id);
Expand Down
2 changes: 1 addition & 1 deletion ...on/Converters/Argumentum.AssetConverter.Tests/MindmapGeneration/SvgPostProcessingTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ public async Task ProcessSvgFilesAsync_WithSimpleSvg_ShouldMatchApprovedSnapshot
var processedSvgContent = FallacyMindMapDocumentConfig.GetSvgContent(processedSvgDocs.Values.First());

// Assert
var snapshotDirectory = Path.Combine(Path.GetDirectoryName(Assembly.GetExecutingAssembly().Location), "snapshots");
var snapshotDirectory = Path.Combine(Path.GetDirectoryName(Assembly.GetExecutingAssembly().Location)!, "snapshots");
var snapshotFile = Path.Combine(snapshotDirectory, "sample_fallacy_map.snapshot.svg");

// Auto-generate snapshot if it doesn't exist (first run)
Expand Down
Loading