Skip to content

test(tests): nullable-cleanup Slice C-2 — MmGenerator XDocument + #715 CS8603 (#710, x0ykyn) #730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsboige merged 1 commit into from
Jul 6, 2026
Merged

test(tests): nullable-cleanup Slice C-2 — MmGenerator XDocument + #715 CS8603 (#710, x0ykyn) #730

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions Generation/Converters/Argumentum.AssetConverter.Tests/MindmapGeneration/MmGeneratorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ public async Task GenerateMmFile_WithValidCsv_ShouldProduceWellFormedXmlWithCorr

var xmlDoc = XDocument.Parse(mmContent);
xmlDoc.Should().NotBeNull();
xmlDoc.Root.Name.LocalName.Should().Be("map");
xmlDoc.Root!.Name.LocalName.Should().Be("map");

// Validate root node (TitleFunc uses TitleExpression = "{item.TextFr}")
xmlDoc.Root.Element("node")?.Attribute("TEXT")?.Value.Should().Be("Sophismes");
Expand Down Expand Up @@ -135,7 +135,7 @@ public async Task CreateFreemindmap_ViaPublicApi_ShouldCreateNonEmptyFile()
var xmlDoc = XDocument.Parse(mmContent);
xmlDoc.Root.Should().NotBeNull();
xmlDoc.Root.Element("node").Should().NotBeNull("La map doit contenir au moins un noeud racine.");
xmlDoc.Root.Element("node").Elements("node").Should().NotBeEmpty("La map doit contenir des noeuds enfants pour les données d'entrée.");
xmlDoc.Root!.Element("node")!.Elements("node").Should().NotBeEmpty("La map doit contenir des noeuds enfants pour les données d'entrée.");
}
finally
{
Expand Down Expand Up @@ -173,7 +173,7 @@ public async Task CreateVirtueMindmap_ShouldCreateNonEmptyFile()
var xmlDoc = XDocument.Parse(mmContent);
xmlDoc.Root.Should().NotBeNull();
xmlDoc.Root.Element("node").Should().NotBeNull("the map should contain a root node.");
xmlDoc.Root.Element("node").Elements("node").Should().NotBeEmpty("the map should contain child nodes.");
xmlDoc.Root!.Element("node")!.Elements("node").Should().NotBeEmpty("the map should contain child nodes.");

// Verify specific virtue nodes exist
mmContent.Should().Contain("Argument pertinent");
Expand Down Expand Up @@ -270,7 +270,7 @@ private static async Task<List<Virtue>> LoadVirtuesFromPathAsync(string csvPath)
/// Walks up from the test bin directory to locate the committed Virtues taxonomy CSV
/// (<c>Cards/Fallacies/Argumentum Virtues - Taxonomy.csv</c>, at the repo root in every checkout).
/// </summary>
private static string FindRepoVirtuesCsv()
private static string? FindRepoVirtuesCsv()
{
var dir = new DirectoryInfo(System.AppContext.BaseDirectory);
for (int i = 0; i < 12 && dir != null; i++, dir = dir.Parent)
Expand Down Expand Up @@ -299,7 +299,7 @@ public async Task VirtueMindMap_GeneratesNativeScript_ForArFaZh(string lang, int
var csvPath = FindRepoVirtuesCsv();
csvPath.Should().NotBeNull("the committed Virtues taxonomy CSV must be locatable from the test bin dir");

var virtues = await LoadVirtuesFromPathAsync(csvPath);
var virtues = await LoadVirtuesFromPathAsync(csvPath!);
virtues.Should().NotBeEmpty();

// Apply the production MindMapLocalization for the target language (rewrites the FR-suffixed
Expand Down
Loading