Skip to content

fix(build): replace obsolete WebClient with HttpClient (SYSLIB0014) — zéro-warning résiduel #706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsboige merged 1 commit into from
Jul 5, 2026
Merged

fix(build): replace obsolete WebClient with HttpClient (SYSLIB0014) — zéro-warning résiduel #706

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions Generation/Converters/Argumentum.AssetConverter/Tests/TranslationCoverageReport.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
using System;
using System.Collections.Generic;
using System.IO;
using System.Net.Http;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
Expand All @@ -18,6 +19,11 @@ namespace Argumentum.AssetConverter.Tests
/// </summary>
public class TranslationCoverageReport
{
// HttpClient is intended to be instantiated once and reused (SYSLIB0014: WebClient is
// obsolete since .NET 6 — sockets exhaustion + obsolescence). Static field = one instance
// for the lifetime of the report generator.
private static readonly HttpClient _httpClient = new HttpClient();

private readonly AssetConverterConfig _config;
private readonly TranslationCoverageConfig _coverageConfig;
private readonly Dictionary<string, Dictionary<string, Dictionary<string, double>>> _coverageData;
Expand Down Expand Up @@ -124,12 +130,9 @@ private async Task<List<Fallacy>> LoadTaxonomyData()
List<Fallacy> fallacies;
if (taxonomyFilePath.StartsWith("http", StringComparison.OrdinalIgnoreCase))
{
// Télécharger le fichier depuis l'URL
using (var client = new System.Net.WebClient())
{
string csvContent = await client.DownloadStringTaskAsync(taxonomyFilePath);
fallacies = ParseCsvContent(csvContent);
}
// Télécharger le fichier depuis l'URL (HttpClient remplace WebClient, obsolète SYSLIB0014)
string csvContent = await _httpClient.GetStringAsync(taxonomyFilePath);
fallacies = ParseCsvContent(csvContent);
}
else
{
Expand Down
Loading