feat(pnp): #645 Virtues "families overview" subset in Print&Play Light - #649
Merged
Conversation
…Light
Per jsboige (interactive, verified 2026-07-02): include a subset of Virtues in
the Light Print&Play. Chosen subset = the compact "virtue families overview":
the taxonomy root + 7 family heads (8 cards), marked via a new `print_and_play`
column in the Virtues CSV (mirrors the Fallacies/Scenarii selection idiom).
- Cards CSV: add `print_and_play` column, mark 8 rows (pk 0,1,34,59,79,134,152,179
= card==1 & depth in {0,1}). Surgical column-append — removing it reproduces the
original byte-for-byte; BOM + CRLF preserved, no re-quoting of existing fields.
- Config: new KnownCardSets.VirtuesPrintAndPlayLight + CardSetConfig (clone of
Virtues, filter print_and_play=1) + DocumentCardSet in the Light Tarot P&P doc
(ConvertToCmyk=true, 113x60mm, mirrors Standard Virtues).
Build clean; tests 556/1/5 (0 regression; sole fail = pre-existing OWL #133).
Relates #645, #642 (decision D), #134.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This was referenced Jul 2, 2026
jsboige
added a commit
that referenced
this pull request
Jul 4, 2026
RENDUS + path CMYK (#675) Refresh the release-validation dossier (PR #631) to reflect the 2026-07-03/04 state. ai-01 dispatch tbxfhu (tertiary). Key updates: - 64→80 PDFs: bundle v3 (10 types × 8 langues, expansion P&P #648-650 = P&P Standard + P&P Light). Bundle GDrive v3 = 6.5 GB (80 CMYK + 7 samples + CMYK_COLOR_PROOF.txt). - Verdict #140 (content, 8 langs) = PASS ai-01 RENDU: carte dense p51 EN/ES/RU/AR/FA/ZH (RTL AR+FA, CJK), covers, PT #306 fixé, FR Rules 5 jeux. #119, recto-verso, #216, micro-RU résolu. - Verdict #632 (colorimetric) = PASS ai-01 RENDU: DeviceCMYK 4-comp + GTS_PDFX/OutputIntent on fr+ar+zh. - Finding 1 (CMYK absent) → RÉSOLU: post-process Ghostscript (#632/#652) = 80/80 DeviceCMYK + OutputIntent SWOP. Le path DocumentCardSet.cs (oxymore PNG) est remplacé par le post-process GS sur le PDF final. - Tag v0.9.0: techniquement débloqué (2 verdicts PASS). Reste arbitrages jsboige (#636 §1 SVG Virtues, #654 mnémoniques, couplage go-live DNN) + finding titre PT (§3.6; note: #640 a résolu le bulk 'English Channel' 23 occ HIGH, titre Tarot PT spécifique possiblement inclus). Master ref 3e2fa0c → a41cbda. Bundles Debug/Release-v1 préservés. Relates: #631 #632 #652 #648 #649 #650 #140 #134. ai-01 dispatch tbxfhu. Co-authored-by: Claude-Code <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(pnp): Virtues "families overview" subset in Print&Play Light — #645 follow-up
Suite directe de #645/#648 (P&P Standard + Light). Décision jsboige, interactif ai-01, VÉRIFIÉ 2026-07-02 :
Le doc Light
Argumentum_TarotCards_Print&Play_Light_A4_fr.pdflivré par #648 n'avait pas de Virtues. Cette PR en ajoute un subset, avec choix délégué (à valider en review).Choix du subset (délégué à ai-01)
« Aperçu des familles de vertus » = la racine de la taxonomie + les 7 têtes de famille = 8 cartes. C'est le sous-ensemble le plus compact et le plus lisible : il montre toute l'étendue des vertus (une carte par famille colorée du jeu) sans déverser les 113 cartes.
Sélection =
card==1 AND depth ∈ {0,1}(vérifié : exactement ces 8 pk). Facilement extensible : pour un échantillon plus riche, il suffit de marquer d'autres lignesprint_and_play=1(ex.depth<=2→ 24 cartes) — dis-moi si tu veux plus large.Changements
Cards/Fallacies/Argumentum Virtues - Taxonomy.csv: ajout d'une colonneprint_and_play, 8 lignes marquées1. Édition chirurgicale — retirer la colonne reproduit l'original au byte près ; BOM + CRLF préservés, aucun re-quoting des champs existants (le round-trip csv QUOTE_MINIMAL est byte-identique, vérifié avant/après).CardSetInfo.cs: nouveauKnownCardSets.VirtuesPrintAndPlayLight.WebBasedGeneratorConfig.cs: nouveauCardSetConfig(clone exact deVirtues, seul le filtre passe decard=1àprint_and_play=1) +DocumentCardSetdans le doc Tarot Light (ConvertToCmyk=true, 113×60mm — miroir des Virtues Standard).Discipline
.Replace("\n","\\n"), pas deRowsetNbforcé, pas derscount=0). Le filtre lit la colonne CSV brute par nom (row[csvFilterField]), path déjà prouvé par le CardSetVirtues(card=1→ 113 images).AssetConverterConfig.jsonnon touché (généré,.gitignore).Validation restante (hors PR, lane régén)
Le rendu PDF réel des 8 cartes Virtues dans le Light se valide à la régénération bundle v3 (lane po-2023 + verdict visuel ai-01).
Relates #645, #642 (décision D), #134 (release v0.9.0).
🤖 ai-01