Skip to content

build: close NU1903 (AutoMapper CVE) while staying on the last free MIT version #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsboige merged 1 commit into from
Jun 23, 2026
Merged

build: close NU1903 (AutoMapper CVE) while staying on the last free MIT version #588

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion Generation/Converters/Argumentum.AssetConverter/Argumentum.AssetConverter.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,18 @@
<PackageReference Include="Utf8Json" Version="1.3.7" />
<PackageReference Include="xunit.extensibility.core" Version="2.8.1" />
</ItemGroup>


<!-- NU1903: AutoMapper 14.0.0 carries GHSA-rvv3-g6hj-g44x (DoS via uncontrolled recursion). We stay on
14.0.0 — the LAST free MIT version; 15.0.0+ is the commercial dual-licensed line — to keep this OSS
repo MIT-pure (decision jsboige 2026-06-23). The vuln is NOT reachable here: the only AutoMapper
Profile is a flat, acyclic map (Entities/MappingProfile.cs) with an explicit MaxDepth(1) guard, so
the vulnerable recursion path is never taken. No free patched version exists (14.x gets no fix), so
this single advisory is suppressed with justification rather than "fixed" by adopting a commercial
dependency. Targeted suppression (this advisory only), not a blanket NoWarn. -->
<ItemGroup>
<NuGetAuditSuppress Include="https://github.com/advisories/GHSA-rvv3-g6hj-g44x" />
</ItemGroup>

<ItemGroup>
<Folder Include="Data\Target\" />
<Folder Include="Published\v1.3\" />
Expand Down
9 changes: 8 additions & 1 deletion Generation/Converters/Argumentum.AssetConverter/Entities/MappingProfile.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,13 @@ public MappingProfile()
.ForMember(dest => dest.FamilleCamelCase, opt => opt.MapFrom(src => src.FamilyFrCamelcase))
.ForMember(dest => dest.Carte, opt => opt.MapFrom(src => string.IsNullOrEmpty(src.Card) ? (int?)null : int.Parse(src.Card)))
.ForMember(dest => dest.DecimalPath, opt => opt.MapFrom(src => Decimal.Parse(src.DecimalPathPadded).ToString(CultureInfo.InvariantCulture)))
.ReverseMap();
// Belt-and-suspenders for GHSA-rvv3-g6hj-g44x (DoS via uncontrolled recursion). This map is
// flat and acyclic — only scalar ForMember projections — so the vulnerable recursion path is
// never taken on AutoMapper 14.0.0 (the last free MIT version). MaxDepth(1) makes that bound
// explicit on both directions, mirroring the vendor's MaxDepth-default fix, so the NU1903
// audit suppression in the .csproj is defensible rather than blind.
.MaxDepth(1)
.ReverseMap()
.MaxDepth(1);
}
}
Loading