Skip to content

docs(release): v0.9.0 sur-pièce validation brief for jsboige (Sunday) - #462

Merged
jsboige merged 1 commit into
masterfrom
docs/release-v0.9.0-validation-brief
Jun 13, 2026
Merged

docs(release): v0.9.0 sur-pièce validation brief for jsboige (Sunday)#462
jsboige merged 1 commit into
masterfrom
docs/release-v0.9.0-validation-brief

Conversation

@jsboige

@jsboige jsboige commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

Clean presentation of #456 (CHANGELOG + RELEASE-NOTES) for jsboige's interactive Sunday validation, with 3 discrepancies surfaced honestly.

Deliverable: docs/release-v0.9.0-validation-brief.md — structured brief with checklist.

Patch by po-2023, applied by ai-01.
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com

Clean presentation of #456 (CHANGELOG + RELEASE-NOTES) for jsboige's
interactive Sunday validation, with 3 discrepancies surfaced honestly:

- MATERIAL: MindMap SVGs claimed for all 8 langs but only FR/EN/RU/PT
  committed (21 SVGs); ES/AR/FA/ZH absent. RELEASE-NOTES L92 admits AR/FA/ZH
  pending but omits ES and contradicts its own L35 table. Decision needed:
  (A) run Track 1a regen (GUI/attended) or (B) align docs to 4+4.
- MINOR: per-type asset counts (L31-34) don't reconcile to actual 8 types x
  8 langs = 64 PDFs structure (Tarot ~64 looks like grand total mislabeled).
- TRIVIAL: date placeholders (2026-06-XX / TBD) to fill at tag time.

Ground-truth verified locally: 64 PDFs = 8 doc types x 8 langs, ~9834 images,
155/0/5 tests. Release gate untouched — this is prep, not a GO.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

@clusterManager-Myia clusterManager-Myia left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[NanoClaw]

Single-file docs PR — validation brief for v0.9.0 release notes. No code changes, no secrets. Quick pass:

Structure & tone — Well-organized brief with honest discrepancy analysis. The 3-tier severity (material / minor / trivial) is a good framing for the owner's Sunday review. French-first prose matches the target audience.

Content observations:

  1. MindMap discrepancy (§3.1) — Correctly identified as material. CHANGELOG and RELEASE-NOTES contradict each other (4 vs 8 languages), and RELEASE-NOTES L92 only partially acknowledges the gap (AR/FA/ZH pending, omits ES). The two proposed options (regen vs align docs) are reasonable and the recommendation is appropriately deferred to the owner.

  2. Asset table counts (§3.2) — Valid point. The per-type counts (~64, ~16, ~16, ~8) don't individually match the 8 types actually present and a reader could sum them to ~104 expecting that many PDFs. The suggested fix (8 types x 8 langs = 64 total) is cleaner.

  3. Date placeholders (§3.3) — Correct that these are expected pre-tag. No action needed now.

  4. DNN i18n bug mention (§4) — Good cross-reference to #457. Correctly scoped as "not a release blocker for card assets."

Minor nit: The brief references PR #454 and #457, commit 7b57251e, and test counts — these are factual anchors that help the owner validate. No issues there.

Verdict: LGTM as a preparation artifact. The discrepancies it surfaces are real and the defer-to-owner framing is appropriate. No code risk.

@jsboige
jsboige merged commit 6f59161 into master Jun 13, 2026
3 checks passed
@jsboige
jsboige deleted the docs/release-v0.9.0-validation-brief branch June 13, 2026 07:56
jsboige added a commit that referenced this pull request Jun 14, 2026
…t 155->159 (#469)

The v0.9.0 validation brief (PR #462) was written from a pre-#460 reading
and flagged doc discrepancies that #460 had already resolved, plus it
under-reported the test count.

Corrections (3 files, docs-only):

1. release-v0.9.0-validation-brief.md - reframe §3.1/§3.2 as RESOLVED by
   PR #460 (36124be): MindMap SVGs correctly state FR/EN/RU/PT committed
   (21) + ES/AR/FA/ZH pending (CHANGELOG L16, RELEASE-NOTES L25/L35/L92);
   Generated Assets counts reconciled to 64 (Tarot 24 + Poker 16 + Web 24).
   Simplifies jsboige's residual decision to: regenerate MindMaps 8-lang
   (Track 1a, option A) vs status quo (option B, already applied by #460).
   Also fixes a structural duplication in the prior commit (stale §3.1 RED
   / §3.2 YELLOW sections that should have been removed) and adds §3.4.

2. §3.4 (new) - test-count drift: CHANGELOG L70 + RELEASE-NOTES L46 said
   155 tests, but dashboard reports 159 after #465/#28. Verified by grep
   [Fact]/[Theory]: Issue28TargetDissociationTests.cs = 4 tests; #466/#467
   /#468 are doc-only / Enabled=false config -> 0 runtime tests. 155+4=159.

3. CHANGELOG.md L70 + RELEASE-NOTES-v0.9.0.md L46 - 155 -> 159 tests
   ("+4 from #465/#28 front/back dissociation").

Only §3.3 trivial date placeholders remain (normal, pre-tag). Gate release
unchanged - no tag/launch/merge.

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants