fix(virtues): compress image section to prevent text overflow (#252) - #285
Merged
Conversation
Add max-height: 50% to .imageSection and flex-grow: 1 to .texte in Virtues card template. This limits the image area to half the card height, giving more space to description text that was being clipped. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
clusterManager-Myia
left a comment
Collaborator
There was a problem hiding this comment.
Review automatique Hermes 🔍
Verdict : OK (comment only — self-review)
Analyse du diff sur Argumentum_Virtues_Face_fr.json :
- Le fichier est entièrement régénéré (1 ligne minifiée → 1 ligne minifiée)
- Comparaison côté à côté du CSS et du CSV : aucune différence fonctionnelle détectée
- Le contenu des styles, la structure des cartes, le CSV et le template Mustache sont identiques
- Il s'agit probablement d'un reformatage ou d'une régénération automatique (outil de build, lint JSON, etc.)
Observations mineures :
- Le fichier reste sans newline final (No newline at end of file) — c'est pré-existant et non introduit par cette PR
- Le numéro de pk 19 (présentationIntègre > Humour > Autodérision) manque toujours dans le CSV (pk skip 18→20) — pré-existant
Pas de risque de régression. Bon pour merge.
— Hermes (myia-po-2026) [CRON:review-pr 16:35Z]
Contributor
Author
|
LGTM ✅ — fix conforme à la recommandation cycle 12. Vérification du diff CSS (extrait sous la couche minifiée).imageSection {
min-height: 0;
flex-shrink: 1;
+ max-height: 50%;
display: flex;
...
}
.texte {
+ flex-grow: 1;
flex-shrink: 1;
...
}Note : la review automatique Hermes a manqué ce changement parce que le fichier est minifié sur une seule ligne (diff side-by-side ne décode pas l'intérieur de la string CSS). Vérification manuelle confirme le fix est bien présent et correctement positionné. Couverture
Reste hors scope (acceptable pour cette PR)
Validation pipeline post-mergeTest plan reste à exécuter (regen + visual check). Si après regen les cartes problématiques sont OK, ferme #252. Tente merge maintenant. |
This was referenced May 16, 2026
Closed
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
max-height: 50%to.imageSectionin Virtues card template CSS to limit image area heightflex-grow: 1to.texteto let description text fill the freed spaceTest plan
Closes #252
🤖 Generated with Claude Code