Skip to content

fix(config): correct ReleaseCardpenUrl — GitHub Pages root - #281

Merged
jsboige merged 1 commit into
masterfrom
fix/279-release-cardpen-url
May 16, 2026
Merged

fix(config): correct ReleaseCardpenUrl — GitHub Pages root#281
jsboige merged 1 commit into
masterfrom
fix/279-release-cardpen-url

Conversation

@jsboige

@jsboige jsboige commented May 16, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Fix ReleaseCardpenUrl from 404 to working GitHub Pages URL
  • The Pages workflow deploys CardPen to repo root, not /Generation/CardPen/

Proof

$ curl -sI https://argumentumgames.github.io/Argumentum/index.html
HTTP/1.1 200 OK
Content-Length: 11510

$ curl -sI https://argumentumgames.github.io/Argumentum/Generation/CardPen/index.html
HTTP/1.1 404 Not Found

Test plan

  • dotnet build — 0 errors
  • curl -I confirms new URL returns 200 OK
  • Verify UseLocalCardpen = false + dotnet run resolves CardPen correctly (requires network access)

Closes #279

🤖 Generated with Claude Code

#279)

The Pages workflow deploys CardPen to the repo root, not /Generation/CardPen/.
The old URL returned 404, breaking `dotnet run -c Release` for clone-and-run.

Before: https://argumentumgames.github.io/Argumentum/Generation/CardPen/index.html → 404
After:  https://argumentumgames.github.io/Argumentum/index.html → 200 OK

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@jsboige

jsboige commented May 16, 2026

Copy link
Copy Markdown
Contributor Author

LGTM ✅

Vérifications cross-check :

  • Diff 1 ligne, scope chirurgical comme demandé
  • curl -I https://argumentumgames.github.io/Argumentum/index.html200 OK (vérifié indépendamment)
  • curl -I https://argumentumgames.github.io/Argumentum/Generation/CardPen/index.html404 (confirme le bug original)
  • GitGuardian SUCCESS
  • Build claim 0 errors

ai-01 ne peut pas --approve (même identité GitHub jsboige que l'auteur, comme PR #277). @jsboige — feu vert pour merge quand tu as un slot.

Test plan checkbox "Verify UseLocalCardpen = false + dotnet run resolves CardPen correctly" : non-bloquant pour merge, peut être validé lors du test runtime Release dans #280.

Closes #279. Reste de l'Epic #278 : #280 + tasks 3-7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(config): ReleaseCardpenUrl points to 404 — Pages workflow URL mismatch

1 participant