fix(virtues): extend i18n scaffold to Virtue entity (follow-up to #223) - #229
Merged
Conversation
The earlier commit added the _en/_ru/_pt scaffold to ArgumentVirtue, which turns out to be dead code — it's only referenced in MappingProfile.cs, whose AutoMapper definition is never invoked anywhere. The pipeline actually loads Virtues CSV via CsvType = typeof(Virtue) in AssetConverterConfig.cs:79, mapped by VirtueClassMap. This commit adds the same 21 string properties + .Optional() ClassMap entries to Virtue.cs so the CSV i18n columns are reachable at runtime. ArgumentVirtue scaffold kept for mapping symmetry (cheap to maintain, would break reverse mapping if ever invoked). Thanks to post-commit blind-spot audit that traced CsvType references and discovered the duplicate entity class. Build + 88 tests pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
3 tasks
4 tasks
Collaborator
|
Post-hoc review — PR #229 Verdict: ✅ LGTM — important follow-up fix This PR correctly identifies that PR #223 scaffolded i18n columns on Observations:
Note: It's worth adding a deprecation notice or Clean fix, no regressions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up fix for PR #223 (#218). The merged PR added
_en/_ru/_ptcolumns to the Virtues CSV and scaffolded theArgumentVirtueentity — butArgumentVirtueis dead code. The pipeline actually loads Virtues viaCsvType = typeof(Virtue)in AssetConverterConfig.cs:79, mapped byVirtueClassMap.Without this fix, the 21 new CSV columns are silently ignored at runtime.
What changed
FamilyEn,SubfamilyEn, …,LinkPt) toVirtue.cs.Optional()ClassMap entries inVirtueClassMapSymmetric with the scaffold already in
ArgumentVirtue.cs(kept for reverse-mapping viaMappingProfile.cs, cheap to maintain).Why this got missed in PR #223
Two
Virtueentity classes exist:ArgumentVirtue— referenced only byMappingProfile.CreateMap<ArgumentVirtue, Fallacy>(), which is never invoked (.Map()call absent)Virtue— the one actually used by the pipelineA post-merge blind-spot audit traced
CsvTypereferences and caught this.Test plan
dotnet buildpasses (0 errors, 17 pre-existing warnings)TitleEn/TitleRu/TitlePtwhen CSV columns are populated🤖 Generated with Claude Code