fix(mindmap): register Fallacy/Virtue MindMapDocumentConfig in CustomTypeProvider - #187
Merged
Merged
Conversation
…ypeProvider
DynamicExpressionParser uses CardFunc expressions like
{mindMap.GetThumbnailsPath(item)} where mindMap is a concrete
FallacyMindMapDocumentConfig or VirtueMindMapDocumentConfig instance.
GetThumbnailsPath is defined separately on each subclass (no
polymorphic override on base class), so System.Linq.Dynamic.Core
cannot resolve the method when only the base type is registered,
throwing ParseException at runtime.
Fix: register both subclasses alongside the base MindMapDocumentConfig
in CustomTypeProvider.GetCustomTypes().
Bug identified by po-2023 during pipeline run #1 on 2026-04-08.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DynamicExpressionParseris used to resolveCardFuncexpressions like{mindMap.GetThumbnailsPath(item)}wheremindMapis a concreteFallacyMindMapDocumentConfigorVirtueMindMapDocumentConfiginstance.GetThumbnailsPathis defined separately on each subclass (no polymorphic override on the base), soSystem.Linq.Dynamic.Corecannot resolve the method when only the base type is registered inCustomTypeProvider.ParseException: Methods on type 'FallacyMindMapDocumentConfig' are not accessibleat runtime when the Mindmapper mode runs.Fix
Register both subclasses alongside the base
MindMapDocumentConfiginCustomTypeProvider.GetCustomTypes().Context
STATUS/PIPELINE/FIX).Test plan
ParseException(to be verified on next pipeline run)🤖 Generated with Claude Code