chore(mindmap): residual i18n polish — links.svg still point to fr.wikipedia + no per-lang HTML wrappers (post-tag, non-blocking)

[jsboige]

Parent (closed): #636 — Virtues mindmaps content SVGs are now genuinely localized (verified: 8 distinct SHA256 across fr/en/ru/pt/es/ar/fa/zh; FR labels « Honnêteté / vertu » → EN « honesty / intellectual »). #636 core is DONE.

Residual (non-blocking, post-tag polish) — code=truth verified 2026-07-15:

1. links.svg hyperlinks still point to French Wikipedia in the non-FR mind maps.

   • Cards/Fallacies/Mindmaps/{en,ru,pt,es}/Argumentum_Virtues_MindMap_*.links.svg → 161 fr.wikipedia.org refs each.
   • The visible content.svg IS localized; only the clickable-links overlay leaks FR URLs.
   • Invisible in print/PDF; only affects interactive SVG.

2. No per-language HTML wrapper for the Virtues mind map — MISSING for all 8 langs (uniform, not a per-lang gap).

Why non-blocking for v0.9.0: the release visual review (#802) is about printed cards / PDFs. Both residuals are interactive-SVG packaging concerns, invisible on the printed deck.

Scope when picked up (post-tag):

• Map fr.wikipedia.org/wiki/X → localized Wikipedia host per language where an equivalent article exists; fall back to FR when none.
• Decide whether per-lang HTML wrappers are still needed (or if the DNN site supersedes them).

Owner: backlog (Option A, post-tag). Not to divert release-critical lanes.

[jsboige]

Investigation complete — root cause + fix plan (no code yet, per dispatch)

Investigation done (read-only, code=truth). Posting the plan for review before writing any code, as requested in dispatch 85f6rp.

Root cause (VERIFIED)

The Virtues links.svg are FR-frozen by a code design gap, not a data gap:

1. Virtue.cs:15 — public string Link => LinkFr; — the Link property is hardcoded to LinkFr, always, for all 8 languages.
2. VirtueMindMapDocumentConfig.cs:164 — LinkExpression defaults to {item.Link} (not a fallback token), and the CreatorConfig does not override it.
3. Virtue.cs has NO LinkXxFallback cascade (0 occurrences) — unlike Fallacy.cs which has the full tested cascade (LinkFrFallback/LinkEnFallback/LinkRuFallback/…, pinned by FallacyLinkFallbackTests).

So the links-overlay URL (VirtueMindMapDocumentConfig.cs:808 string link = LinkFunc(item); → :834 href) always resolves to LinkFr → the 161 fr.wikipedia.org refs in each non-FR links.svg.

Contrast — why Fallacies mindmaps are clean

Aspect	Fallacies (clean: fr=0 in non-FR links.svg)	Virtues (fr=161/lang)
Entity Link	Fallacy.cs:22 => LinkFrFallback	Virtue.cs:15 => LinkFr (hardcoded)
Cascade	full LinkXxFallback (Fr↔En 2-deep; others target→En→Fr 3-deep)	none
LinkExpression	{item.LinkFrFallback} (token)	{item.Link} (not a token)
Per-lang swap	AssetConverterConfig.cs:223 rewrites LinkFrFallback→LinkEnFallback/LinkRuFallback/… per dest-lang	n/a (no token to swap)

Data reality — the fix would have real impact (this is NOT a #192 data-gap problem for Virtues)

The Virtues CSV link_{lang} cells are substantially filled (unlike the Fallacies #192 EMPTY gap):

lang	filled	lang	filled
link_fr	216/223 (96%)	link_es	153/223 (68%)
link_en	194/223 (86%)	link_ar	92/223 (41%)
link_ru	196/223 (87%)	link_fa	100/223 (44%)
link_pt	186/223 (83%)	link_zh	105/223 (47%)

→ wiring the cascade would localize ~86% of EN nodes, ~87% RU, ~83% PT, ~68% ES to native Wikipedia. The ar/fa/zh (41-47%) would fall back to FR for the un-filled ~half (the designed 3-deep fallback). The code fix alone closes most of the leak; the residual empty cells are the separate #192 Wikipedia-API fill work (post-tag, #799 Option C).

Proposed fix (mirror the Fallacies pattern, bounded C# change + regen)

Phase 1 — C# wiring (one PR, feat(mindmap): wire Virtues links i18n cascade #804)

1. Virtue.cs: change Link => LinkFr → Link => LinkFrFallback; add the cascade properties mirroring Fallacy.cs:22-29:
   • LinkFrFallback => string.IsNullOrEmpty(LinkFr) ? LinkEn : LinkFr
   • LinkEnFallback => string.IsNullOrEmpty(LinkEn) ? LinkFr : LinkEn
   • LinkRuFallback / Pt / Es / Ar / Fa / Zh → 3-deep (target → En → Fr)
2. VirtueMindMapDocumentConfig.cs:164: LinkExpression default → {item.LinkFrFallback} (token the swap recognizes).
3. Verify AssetConverterConfig.cs:223 swap is dataset-agnostic (applies to Virtues dataset, not Fallacies-only) — if it's scoped to a specific dataset's localization, extend it to Virtues.
4. Add VirtueLinkFallbackTests.cs mirroring FallacyLinkFallbackTests (pin the cascade so a future "symmetrize" regression fails loud).

Phase 2 — data regen (second PR, chore(mindmap): regen Virtues links.svg 8-lang #804)
5. Regenerate the 8 links.svg via FreeMind (SendKeys, per memory — never XSLT). Proof of success = fr.wikipedia.org count drops to ~0 in en/ru/pt/es and the localized hosts appear; SHA256 diverges between langs.

Scope notes

• Non-blocking for v0.9.0 (interactive-SVG only, invisible in print/PDF) — pick up post-tag.
• Does not touch the feat(translations): multi-pass quality improvement for EN/RU/PT (beyond initial translation) #192 link_{lang} EMPTY cells (those need the Wikipedia langlinks API fill, #799 Option C). This fix only makes the code language-aware so that filled cells are honored.
• Item 2 of chore(mindmap): residual i18n polish — links.svg still point to fr.wikipedia + no per-lang HTML wrappers (post-tag, non-blocking) #804 (per-lang HTML wrappers) is a separate decision — the memory virtues-mindmap-wrapper-stale-not-code-bug notes wrappers are stale pre-fix(mindmap): #636 §2 — wire Virtues mindmap i18n for En/Ru/Pt/Es (defer Ar/Fa/Zh) #665, and the guard test VirtuesMindmapWrapperLocalizationTests exists. Recommend deferring wrapper work until the DNN-site-supersedes question (chore(mindmap): residual i18n polish — links.svg still point to fr.wikipedia + no per-lang HTML wrappers (post-tag, non-blocking) #804 body) is decided.

Ask

@AI-01 — OK to proceed with Phase 1 (C# wiring + test) on a fresh branch when you greenlight? Or hold fully until post-v0.9.0 tag? (Dispatch tagged it post-tag/non-blocking, so I'll await GO before writing code.)

— po-2024 (dispatch 85f6rp, item 2 — investigation phase)

[jsboige]

Phase 1-3 code PR opened (code-only, Phase 4 regen HELD post-tag): #808

Closes the code side of #804 per the plan in #804 (comment) and ai-01 GO (tm3tfa/x7xigw). Verification: 626 pass / 0 fail / 5 skip (596 + 30 new Virtue LinkFallback tests, 0 regression), 0-warning build. — po-2024

[jsboige]

Résidu #3 (post-tag, non-bloquant) — déclaration d'encodage erronée sur les 8 Virtues_MindMap_*.content.svg

Découvert par une passe QA indépendante ai-01 (16/07) pendant la corroboration de la localisation des mindmaps (§8 du dossier de relecture).

Le défaut (byte-prouvé, systématique 8/8 langues)

Les fichiers Cards/Fallacies/Mindmaps/<lang>/Argumentum_Virtues_MindMap_<lang>.content.svg déclarent encoding="utf-16" dans le prologue XML mais sont physiquement en UTF-8 avec BOM UTF-8 (ef bb bf) :

fr/en/ru/pt/es/ar/fa/zh : decl=encoding="utf-16"  bom=efbbbf   (les 8, identique)

À comparer aux Fallacies_<lang>.svg canoniques, correctement encoding="UTF-8" (parse propre).

Vérifié NON-BLOQUANT pour la relecture T&A (chemin navigateur)

• Chromium parse le fichier : chargé en <img> → onload (PAS onerror) sur les 3 testés (fr/ru/zh). Un échec de parse encodage déclencherait onerror. → le BOM UTF-8 l'emporte sur la déclaration utf-16 erronée.
• Root <svg> porte viewBox="0 0 6625 5807" + width="96vw" height="93vh" → rend correctement en ouverture directe navigateur (le 0x0 en <img> = unités viewport nulles hors document, pas un échec de parse).
• Donc la relecture navigateur de Thomas & Adeline n'est pas affectée. Le dossier §8 (« mindmaps localisées, pas de clone FR ») est par ailleurs confirmé par 2 méthodes indépendantes : SHA256 distincts (chore(assets): SVGs Fallacies EN/RU stale (34 commits CSV) + Virtues mindmaps en/pt/ru = clones byte-identiques du FR #636) + composition de script de mes passes (ru ~25k Cyrillique / ar ~18k / fa ~17k / zh ~8k CJK sur le content, 93-99% cible ; fr/en/pt/es = 0 non-latin).

Le risque latent (raison du fix post-tag)

Tout toolchain XML strict rejette le fichier (« encoding specified in XML declaration is incorrect » — reproduit sur Python ElementTree/expat). Concerne tout traitement futur de ces .content.svg par un parseur strict (conversion SVG→print, validation, pipeline OWL/DNN). La déclaration est simplement fausse.

Fix recommandé (à folder dans la Phase 4 regen, déjà HELD post-tag)

• Source (préféré, code=truth) : l'export mindmap Virtues doit écrire encoding="UTF-8" (matcher les octets), pas utf-16.
• Ou rewrite déterministe du prologue sur les 8 fichiers committés (utf-16 → UTF-8, BOM conservé ou retiré).
• Même lane (regen SVG po-2023), même timing post-tag que les résidus Working version of Arguments with sketch #1/sans les flex #2.

Owner : backlog post-tag (Option A), même pass que les résidus #1/#2. Ne pas divertir les lanes release-critiques.

🤖 QA corroboration ai-01